Skip to content
Snippets Groups Projects
Commit ffded1d1 authored by srosse's avatar srosse
Browse files

OO-1267: remove the olat resource after the repository entry is removed

parent 892b8cc9
No related branches found
No related tags found
No related merge requests found
...@@ -40,8 +40,6 @@ import org.olat.core.util.coordinate.SyncerCallback; ...@@ -40,8 +40,6 @@ import org.olat.core.util.coordinate.SyncerCallback;
import org.olat.core.util.vfs.VFSContainer; import org.olat.core.util.vfs.VFSContainer;
import org.olat.core.util.vfs.VFSItem; import org.olat.core.util.vfs.VFSItem;
import org.olat.fileresource.types.FileResource; import org.olat.fileresource.types.FileResource;
import org.olat.resource.OLATResource;
import org.olat.resource.OLATResourceManager;
/** /**
* Initial Date: Apr 8, 2004 * Initial Date: Apr 8, 2004
...@@ -74,10 +72,6 @@ public class FileResourceManager extends BasicManager { ...@@ -74,10 +72,6 @@ public class FileResourceManager extends BasicManager {
// delete resources // delete resources
File fResourceFileroot = getFileResourceRoot(res); File fResourceFileroot = getFileResourceRoot(res);
FileUtils.deleteDirsAndFiles(fResourceFileroot, true, true); FileUtils.deleteDirsAndFiles(fResourceFileroot, true, true);
// delete resourceable
OLATResourceManager rm = OLATResourceManager.getInstance();
OLATResource ores = rm.findResourceable(res);
if (ores != null) rm.deleteOLATResource(ores);
} }
/** /**
......
...@@ -254,6 +254,7 @@ public class RepositoryServiceImpl implements RepositoryService { ...@@ -254,6 +254,7 @@ public class RepositoryServiceImpl implements RepositoryService {
//delete all policies //delete all policies
securityManager.deletePolicies(resource); securityManager.deletePolicies(resource);
dbInstance.commit();
// inform handler to do any cleanup work... handler must delete the // inform handler to do any cleanup work... handler must delete the
// referenced resourceable a swell. // referenced resourceable a swell.
...@@ -276,7 +277,8 @@ public class RepositoryServiceImpl implements RepositoryService { ...@@ -276,7 +277,8 @@ public class RepositoryServiceImpl implements RepositoryService {
public void deleteRepositoryEntryAndBaseGroups(RepositoryEntry entry) { public void deleteRepositoryEntryAndBaseGroups(RepositoryEntry entry) {
RepositoryEntry reloadedEntry = dbInstance.getCurrentEntityManager() RepositoryEntry reloadedEntry = dbInstance.getCurrentEntityManager()
.getReference(RepositoryEntry.class, entry.getKey()); .getReference(RepositoryEntry.class, entry.getKey());
OLATResource resource = reloadedEntry.getOlatResource();
Group defaultGroup = reToGroupDao.getDefaultGroup(reloadedEntry); Group defaultGroup = reToGroupDao.getDefaultGroup(reloadedEntry);
groupDao.removeMemberships(defaultGroup); groupDao.removeMemberships(defaultGroup);
reToGroupDao.removeRelations(reloadedEntry); reToGroupDao.removeRelations(reloadedEntry);
...@@ -284,6 +286,9 @@ public class RepositoryServiceImpl implements RepositoryService { ...@@ -284,6 +286,9 @@ public class RepositoryServiceImpl implements RepositoryService {
dbInstance.getCurrentEntityManager().remove(reloadedEntry); dbInstance.getCurrentEntityManager().remove(reloadedEntry);
groupDao.removeGroup(defaultGroup); groupDao.removeGroup(defaultGroup);
dbInstance.commit(); dbInstance.commit();
dbInstance.getCurrentEntityManager().remove(resource);
dbInstance.commit();
} }
@Override @Override
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment