OO-1453: better handling of unexpected exceptions

src/main/java/org/olat/ldap/LDAPLoginManager.java

@@ -39,7 +39,7 @@ public interface LDAPLoginManager {
 
 	public Attributes bindUser(String uid, String pwd, LDAPError errors);
 
-	public void changePassword(Identity identity, String pwd, LDAPError errors);
+	public boolean changePassword(Identity identity, String pwd, LDAPError errors);
 	
 	public Identity createAndPersistUser(Attributes userAttributes);
 	

src/main/java/org/olat/ldap/manager/LDAPLoginManagerImpl.java

@@ -277,13 +277,12 @@ public class LDAPLoginManagerImpl implements LDAPLoginManager, GenericEventListe
 		}
 	}
 	
-
 	/**
 	 * Change the password on the LDAP server.
 	 * @see org.olat.ldap.LDAPLoginManager#changePassword(org.olat.core.id.Identity, java.lang.String, org.olat.ldap.LDAPError)
 	 */
 	@Override
-	public void changePassword(Identity identity, String pwd, LDAPError errors) {
+	public boolean changePassword(Identity identity, String pwd, LDAPError errors) {
 		String uid = identity.getName();
 		String ldapUserPasswordAttribute = syncConfiguration.getLdapUserPasswordAttribute();
 		try {
@@ -310,15 +309,18 @@ public class LDAPLoginManagerImpl implements LDAPLoginManager, GenericEventListe
 			modificationItems [ 0 ] = new ModificationItem ( DirContext.REPLACE_ATTRIBUTE, userPasswordAttribute );
 			ctx.modifyAttributes ( dn, modificationItems );
 			ctx.close();
+			return true;
 		} catch (NamingException e) {
 			log.error("NamingException when trying to change password with username::" + uid, e);
 			errors.insert("Cannot change the password");
+			return false;
+		} catch(Exception e) {
+			log.error("Unexpected exception when trying to change password with username::" + uid, e);
+			errors.insert("Cannot change the password");
+			return false;
 		}
 	}
 
-
-	
-
 	/**
 	 * Delete all Identities in List and removes them from LDAPSecurityGroup
 	 *