Skip to content
Snippets Groups Projects
Commit ec61df04 authored by gnaegi's avatar gnaegi
Browse files

Merge OpenOLAT 10.3 to OpenOLAT default with 3e28fa86416f480eecec3fc63cf078238d3e624c

parents a529025d 44ef969a
No related branches found
No related tags found
No related merge requests found
...@@ -296,13 +296,13 @@ public class ScormRunController extends BasicController implements ScormAPICallb ...@@ -296,13 +296,13 @@ public class ScormRunController extends BasicController implements ScormAPICallb
attemptsIncremented, deliveryOptions); attemptsIncremented, deliveryOptions);
} else if (chooseScormRunMode.getSelectedElement().equals(ScormConstants.SCORM_MODE_NORMAL)) { } else if (chooseScormRunMode.getSelectedElement().equals(ScormConstants.SCORM_MODE_NORMAL)) {
// When not assessible users can choose between normal mode where data is stored... // When not assessible users can choose between normal mode where data is stored...
scormDispC = ScormMainManager.getInstance().createScormAPIandDisplayController(ureq, getWindowControl(), showMenu, null, scormDispC = ScormMainManager.getInstance().createScormAPIandDisplayController(ureq, getWindowControl(), showMenu, this,
cpRoot, null, courseId + "-" + scormNode.getIdent(), ScormConstants.SCORM_MODE_NORMAL, cpRoot, null, courseId + "-" + scormNode.getIdent(), ScormConstants.SCORM_MODE_NORMAL,
ScormConstants.SCORM_MODE_CREDIT, false, assessableType, doActivate, fullWindow, ScormConstants.SCORM_MODE_CREDIT, false, assessableType, doActivate, fullWindow,
attemptsIncremented, deliveryOptions); attemptsIncremented, deliveryOptions);
} else { } else {
// ... and preview mode where no data is stored // ... and preview mode where no data is stored
scormDispC = ScormMainManager.getInstance().createScormAPIandDisplayController(ureq, getWindowControl(), showMenu, null, scormDispC = ScormMainManager.getInstance().createScormAPIandDisplayController(ureq, getWindowControl(), showMenu, this,
cpRoot, null, courseId, ScormConstants.SCORM_MODE_BROWSE, ScormConstants.SCORM_MODE_NOCREDIT, cpRoot, null, courseId, ScormConstants.SCORM_MODE_BROWSE, ScormConstants.SCORM_MODE_NOCREDIT,
false, assessableType, doActivate, fullWindow, attemptsIncremented, deliveryOptions); false, assessableType, doActivate, fullWindow, attemptsIncremented, deliveryOptions);
} }
...@@ -336,7 +336,6 @@ public class ScormRunController extends BasicController implements ScormAPICallb ...@@ -336,7 +336,6 @@ public class ScormRunController extends BasicController implements ScormAPICallb
// //
} }
// <BPS-620>
/** /**
* @see org.olat.modules.scorm.ScormAPICallback#lmsFinish(java.lang.String, * @see org.olat.modules.scorm.ScormAPICallback#lmsFinish(java.lang.String,
* java.util.Properties) * java.util.Properties)
...@@ -348,8 +347,6 @@ public class ScormRunController extends BasicController implements ScormAPICallb ...@@ -348,8 +347,6 @@ public class ScormRunController extends BasicController implements ScormAPICallb
} }
} }
// </BPS-620>
/** /**
* @return true if there is a treemodel and an event listener ready to be * @return true if there is a treemodel and an event listener ready to be
* used in outside this controller * used in outside this controller
......
...@@ -47,12 +47,10 @@ public interface ScormAPICallback { ...@@ -47,12 +47,10 @@ public interface ScormAPICallback {
*/ */
void lmsCommit(String olatSahsId, Properties scoScores, Properties scoLessonStatus); void lmsCommit(String olatSahsId, Properties scoScores, Properties scoLessonStatus);
// <OLATCE-289>
/** /**
* @param olatSahsId * @param olatSahsId
* @param scoScores properties with key: scoId, value = rawscore * @param scoScores properties with key: scoId, value = rawscore
*/ */
void lmsFinish(String olatSahsId, Properties scoProps, Properties scoLessonStatus); void lmsFinish(String olatSahsId, Properties scoProps, Properties scoLessonStatus);
// </OLATCE-289>
} }
...@@ -198,7 +198,7 @@ function olatonunload(){ ...@@ -198,7 +198,7 @@ function olatonunload(){
iframeDoc.location.replace("about:blank"); iframeDoc.location.replace("about:blank");
iframeDoc = null; iframeDoc = null;
//delay(200); //delay(200);
//if((new Date().getTime() - lastRequest) > 60000) alert("Current SCO will be finised befor initializing next SCO or terminating! Press OK to proceed."); //if((new Date().getTime() - lastRequest) > 60000) alert("Current SCO will be finished before initializing next SCO or terminating! Press OK to proceed.");
var delayReq = new XMLHttpRequest(); var delayReq = new XMLHttpRequest();
//"false" waits until the result arrived; //"false" waits until the result arrived;
......
...@@ -277,9 +277,9 @@ ...@@ -277,9 +277,9 @@
align: 'center', align: 'center',
spacing: 5, spacing: 5,
items: [ items: [
{name: 'width', type: 'textbox', maxLength: 3, size: 3, onchange: generatePreview}, {name: 'width', type: 'textbox', maxLength: 4, size: 4, onchange: generatePreview},
{type: 'label', text: 'x'}, {type: 'label', text: 'x'},
{name: 'height', type: 'textbox', maxLength: 3, size: 3, onchange: generatePreview} {name: 'height', type: 'textbox', maxLength: 4, size: 4, onchange: generatePreview}
] ]
}, },
{ name: 'preview', type: 'panel', label: '', minHeight: 320, { name: 'preview', type: 'panel', label: '', minHeight: 320,
......
No preview for this file type
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment