OO-3911: hide OpenMeetings password after validation and check

src/main/java/org/olat/modules/openmeetings/OpenMeetingsModule.java

@@ -192,7 +192,7 @@ public class OpenMeetingsModule  extends AbstractSpringModule implements ConfigO
 	}
 
 	public void setAdminPassword(String adminPassword) {
-		setStringProperty(ADMIN_PASSWORD, adminPassword, true);
+		setSecretStringProperty(ADMIN_PASSWORD, adminPassword, true);
 	}
 	
 }

src/main/java/org/olat/modules/openmeetings/ui/OpenMeetingsConfigurationController.java

@@ -63,6 +63,8 @@ public class OpenMeetingsConfigurationController extends FormBasicController {
 	private static final String[] enabledKeys = new String[]{"on"};
 	private String[] enabledValues;
 	
+	private String replacedValue;
+	
 	@Autowired
 	private OpenMeetingsModule openMeetingsModule;
 	@Autowired
@@ -97,11 +99,12 @@ public class OpenMeetingsConfigurationController extends FormBasicController {
 			urlEl.setDisplaySize(60);
 			String login = openMeetingsModule.getAdminLogin();
 			loginEl = uifactory.addTextElement("openmeetings-login", "option.adminlogin", 32, login, moduleFlc);
-			String password = openMeetingsModule.getAdminPassword();
-			if(StringHelper.containsNonWhitespace(password)) {
-				password = PLACEHOLDER;
+			String credential = openMeetingsModule.getAdminPassword();
+			if(StringHelper.containsNonWhitespace(credential)) {
+				replacedValue = credential;
+				credential = PLACEHOLDER;
 			}
-			passwordEl = uifactory.addPasswordElement("openmeetings-password", "option.adminpassword", 32, password, moduleFlc);
+			passwordEl = uifactory.addPasswordElement("openmeetings-password", "option.adminpassword", 32, credential, moduleFlc);
 			passwordEl.setAutocomplete("new-password");
 			
 			String externalType = openMeetingsManager.getOpenOLATExternalType();
@@ -129,9 +132,12 @@ public class OpenMeetingsConfigurationController extends FormBasicController {
 			String login = loginEl.getValue();
 			openMeetingsModule.setAdminLogin(login);
 			
-			String password = passwordEl.getValue();
-			if(!PLACEHOLDER.equals(password)) {
-				openMeetingsModule.setAdminPassword(password);
+			String credential = passwordEl.getValue();
+			if(!PLACEHOLDER.equals(credential)) {
+				openMeetingsModule.setAdminPassword(credential);
+				passwordEl.setValue(PLACEHOLDER);
+			} else if(StringHelper.containsNonWhitespace(replacedValue)) {
+				openMeetingsModule.setAdminPassword(replacedValue);
 			}
 		} catch (URISyntaxException e) {
 			logError("", e);
@@ -151,12 +157,20 @@ public class OpenMeetingsConfigurationController extends FormBasicController {
 			allOk &= validateURL();
 
 			try {
-				String password = passwordEl.getValue();
-				if(PLACEHOLDER.equals(password)) {
-					password = openMeetingsModule.getAdminPassword();
+				String credential = passwordEl.getValue();
+				if(PLACEHOLDER.equals(credential)) {
+					if(StringHelper.containsNonWhitespace(replacedValue)) {
+						credential = replacedValue;
+					} else {
+						credential = openMeetingsModule.getAdminPassword();
+					}
+				} else {
+					replacedValue = credential;
+					passwordEl.setValue(PLACEHOLDER);
 				}
-				boolean ok = openMeetingsManager.checkConnection(urlEl.getValue(), loginEl.getValue(), password);
+				boolean ok = openMeetingsManager.checkConnection(urlEl.getValue(), loginEl.getValue(), credential);
 				if(!ok) {
+					passwordEl.setValue("");
 					urlEl.setErrorKey("error.customerDoesntExist", null);
 					allOk = false;
 				}
@@ -222,13 +236,20 @@ public class OpenMeetingsConfigurationController extends FormBasicController {
 	protected boolean checkConnection() {
 		String url = urlEl.getValue();
 		String login = loginEl.getValue();
-		String password = passwordEl.getValue();
-		if(PLACEHOLDER.equals(password)) {
-			password = openMeetingsModule.getAdminPassword();
+		String credential = passwordEl.getValue();
+		if(PLACEHOLDER.equals(credential)) {
+			if(StringHelper.containsNonWhitespace(replacedValue)) {
+				credential = replacedValue;
+			} else {
+				credential = openMeetingsModule.getAdminPassword();
+			}
+		} else {
+			replacedValue = credential;
+			passwordEl.setValue(PLACEHOLDER);
 		}
 
 		try {
-			boolean ok = openMeetingsManager.checkConnection(url, login, password);
+			boolean ok = openMeetingsManager.checkConnection(url, login, credential);
 			if(ok) {
 				showInfo("check.ok");
 			} else {