OO-953: return the site of the right type as the classname of the site is the relevant info

src/main/java/org/olat/course/site/CourseSiteDef.java

@@ -98,6 +98,15 @@ public class CourseSiteDef extends AbstractSiteDefinition implements SiteDefinit
 			return null;
 		}
 		String icon = courseConfig.getNavIconCssClass();
+		return createCourseSiteInstance(ureq, langConfig, showToolController, siteSecCallback, icon);
+	}
+	
+	/**
+	 * Warning: there is no check against null.
+	 * It's only to return the right type, CourseSie or CourseSite2.
+	 */
+	protected CourseSite createCourseSiteInstance(UserRequest ureq, LanguageConfiguration langConfig,
+			boolean showToolController, SiteSecurityCallback siteSecCallback, String icon) {
 		return new CourseSite(this, ureq.getLocale(), langConfig.getRepoSoftKey(), showToolController,
 				siteSecCallback, langConfig.getTitle(), icon);
 	}

src/main/java/org/olat/course/site/CourseSiteDef2.java

@@ -20,8 +20,11 @@
 package org.olat.course.site;
 
 import org.olat.core.CoreSpringFactory;
+import org.olat.core.gui.UserRequest;
 import org.olat.core.gui.control.navigation.SiteDefinitions;
+import org.olat.core.gui.control.navigation.SiteSecurityCallback;
 import org.olat.course.site.model.CourseSiteConfiguration;
+import org.olat.course.site.model.LanguageConfiguration;
 
 /**
  * 
@@ -39,4 +42,11 @@ public class CourseSiteDef2 extends CourseSiteDef {
 		CourseSiteConfiguration config = siteModule.getConfigurationCourseSite2();
 		return config;
 	}
+
+	@Override
+	protected CourseSite createCourseSiteInstance(UserRequest ureq, LanguageConfiguration langConfig,
+			boolean showToolController, SiteSecurityCallback siteSecCallback, String icon) {
+		return new CourseSite2(this, ureq.getLocale(), langConfig.getRepoSoftKey(), showToolController,
+				siteSecCallback, langConfig.getTitle(), icon);
+	}
 }