OO-2575: better handle error during login with defective business path, fix...

OO-2575: better handle error during login with defective business path, fix NPE in artefact pool v1 if the portfolio v1 is disabled

src/main/java/org/olat/dispatcher/AuthenticatedDispatcher.java

@@ -328,6 +328,13 @@ public class AuthenticatedDispatcher implements Dispatcher {
 				Window w = windowBackOffice.getWindow();
 				w.dispatchRequest(ureq, true); // renderOnly
 			} catch (Exception e) {
+				// try to render something
+				try {
+					Window w = windowBackOffice.getWindow();
+					w.dispatchRequest(ureq, true); // renderOnly
+				} catch (Exception e1) {
+					redirectToDefaultDispatcher(ureq.getHttpReq(), ureq.getHttpResp());
+				}
 				log.error("", e);
 			}
 		}

src/main/java/org/olat/portfolio/ui/EPArtefactPoolRunController.java

@@ -123,7 +123,7 @@ public class EPArtefactPoolRunController extends BasicController implements Acti
 
 			putInitialPanel(viewComp);
 		} else {
-			putInitialPanel(new Panel("empty"));
+			putInitialPanel(createVelocityContainer("portfolio_disabled"));
 		}
 	}
 
@@ -278,16 +278,18 @@ public class EPArtefactPoolRunController extends BasicController implements Acti
 	public void activate(UserRequest ureq, List<ContextEntry> entries, StateEntry state) {
 		if(entries == null || entries.isEmpty()) return;
 		
-		String type = entries.get(0).getOLATResourceable().getResourceableTypeName();
-		if("All".equalsIgnoreCase(type)) {
-			initTPAllView(ureq);
-			segmentView.select(artefactsLink);
-		} else if("Browse".equalsIgnoreCase(type)) {
-			initTPBrowseView(ureq);
-			segmentView.select(browseLink);
-		} else if("Search".equalsIgnoreCase(type)) {
-			initTPFilterView(ureq);
-			segmentView.select(searchLink);
+		if(portfolioModule.isEnabled()) {
+			String type = entries.get(0).getOLATResourceable().getResourceableTypeName();
+			if("All".equalsIgnoreCase(type)) {
+				initTPAllView(ureq);
+				segmentView.select(artefactsLink);
+			} else if("Browse".equalsIgnoreCase(type)) {
+				initTPBrowseView(ureq);
+				segmentView.select(browseLink);
+			} else if("Search".equalsIgnoreCase(type)) {
+				initTPFilterView(ureq);
+				segmentView.select(searchLink);
+			}
 		}
 	}
 

src/main/java/org/olat/portfolio/ui/_content/portfolio_disabled.html

+<div class="o_warning" role="alert"><i class="o_icon o_icon-fw o_icon_important"> </i> $r.translate("warning.portfolio.module.disabled")</div>
\ No newline at end of file

src/main/java/org/olat/portfolio/ui/_i18n/LocalStrings_de.properties

@@ -52,6 +52,7 @@ view.mode.table=Tabelle
 viewTab.all=Artefakte
 viewTab.browse=Tag-Browser
 viewTab.search=Suche
+warning.portfolio.module.disabled=ePortfolio v1 ist nicht eingeschaltet.
 wizard.intro=Das Artefakt-Sammelwerkzeug enth\u00E4lt verschiedene Schritte in einem Wizard. Einige der Schritte k\u00F6nnen Sie je nach Bedarf aktivieren oder deaktivieren.
 wizard.step.copyright=Urheberschaft vom Benutzer best\u00E4tigen lassen
 wizard.step.reflexion=Reflexion erfassen

src/main/java/org/olat/portfolio/ui/_i18n/LocalStrings_en.properties

@@ -52,6 +52,7 @@ view.mode.table=Table
 viewTab.all=Artefacts
 viewTab.browse=Tag browser
 viewTab.search=Search
+warning.portfolio.module.disabled=ePortfolio v1 is disabled.
 wizard.intro=Within the accumulative artefact tool there are several steps to complete. Some of them are optional. You can completely disable those steps if not needed.
 wizard.step.copyright=Ask user for copyright
 wizard.step.reflexion=Collect a reflexion