OO-5059: wait a little before drawing paypal smart buttons

src/main/java/org/olat/resource/accesscontrol/provider/paypalcheckout/ui/PaypalSmartButtonAccessController.java

@@ -28,6 +28,7 @@ import org.olat.core.gui.components.htmlheader.jscss.JSAndCSSFormItem;
 import org.olat.core.gui.control.Controller;
 import org.olat.core.gui.control.Event;
 import org.olat.core.gui.control.WindowControl;
+import org.olat.core.util.Formatter;
 import org.olat.core.util.StringHelper;
 import org.olat.resource.accesscontrol.OfferAccess;
 import org.olat.resource.accesscontrol.Price;
@@ -71,9 +72,11 @@ public class PaypalSmartButtonAccessController extends FormBasicController imple
 			layoutCont.contextPut("currency", currency);
 			String excludeFundings = paypalModule.getExcludeFundings();
 			layoutCont.contextPut("excludeFundings", excludeFundings == null ? "" : excludeFundings);
+			layoutCont.contextPut("csrfToken", ureq.getUserSession().getCsrfToken());
 			
 			String description = link.getOffer().getDescription();
 			if(StringHelper.containsNonWhitespace(description)) {
+				description = Formatter.escWithBR(description).toString();
 				description = StringHelper.xssScan(description);
 				layoutCont.contextPut("description", description);
 			}

src/main/java/org/olat/resource/accesscontrol/provider/paypalcheckout/ui/_content/paypal_smart_buttons.html

@@ -18,26 +18,33 @@
 			</div>
 			
 			<div id="paypal_buttons_${r.getCId()}">
-				<script defer>
+				<script defer data-csp-nonce="${csrfToken}">
 				jQuery(function() {
 					jQuery.ajax({
 						url: 'https://www.paypal.com/sdk/js?client-id=$clientId&currency=${currency}&intent=authorize&commit=true&disable-funding=${excludeFundings}',
-						cache: true,
+						cache: true,//paypal don't like the anti-cache parameter
 						dataType: "script",
 						success: loadButtons,
 						error: errorButtons,
 					});
 					
 					function errorButtons() {
-						location.reload();
+						if(window.console) console.log('Errors');
 					}
 					
 					function loadButtons() {
 						try {
-							internalLoadButtons();
+							setTimeout(function() {
+								internalLoadButtons();
+								var numOfPayPal = jQuery('#paypal_buttons_${r.getCId()} iframe').length;
+								if(numOfPayPal == 0) {
+									setTimeout(function() {
+										internalLoadButtons();
+									}, 100);
+								}
+							}, 100);
 						} catch(e) {
 							if(window.console) console.log(e);
-							location.reload();
 						}
 					}