Skip to content
Snippets Groups Projects
Commit b4e75634 authored by srosse's avatar srosse
Browse files

OO-655: remove the "remove" link in the rights mamagement of the course

parent dc7e527d
No related branches found
No related tags found
No related merge requests found
...@@ -89,7 +89,6 @@ public class GroupsAndRightsController extends FormBasicController { ...@@ -89,7 +89,6 @@ public class GroupsAndRightsController extends FormBasicController {
for(String right : CourseRights.getAvailableRights()) { for(String right : CourseRights.getAvailableRights()) {
tableColumnModel.addFlexiColumnModel(new DefaultFlexiColumnModel(right, colIndex++)); tableColumnModel.addFlexiColumnModel(new DefaultFlexiColumnModel(right, colIndex++));
} }
tableColumnModel.addFlexiColumnModel(new DefaultFlexiColumnModel("table.header.remove", colIndex++));
List<BGRightsOption> groupRights = loadModel(); List<BGRightsOption> groupRights = loadModel();
tableDataModel = new GroupsAndRightsDataModel(groupRights, tableColumnModel); tableDataModel = new GroupsAndRightsDataModel(groupRights, tableColumnModel);
...@@ -130,7 +129,6 @@ public class GroupsAndRightsController extends FormBasicController { ...@@ -130,7 +129,6 @@ public class GroupsAndRightsController extends FormBasicController {
fillCheckbox(options, r == null ? null : r.getRights()); fillCheckbox(options, r == null ? null : r.getRights());
FormLink rmLink = uifactory.addFormLink("remove_" + UUID.randomUUID().toString(), "table.header.remove", "table.header.remove", flc, Link.LINK); FormLink rmLink = uifactory.addFormLink("remove_" + UUID.randomUUID().toString(), "table.header.remove", "table.header.remove", flc, Link.LINK);
rmLink.setUserObject(options); rmLink.setUserObject(options);
options.setRemoveLink(rmLink);
return options; return options;
} }
...@@ -168,13 +166,7 @@ public class GroupsAndRightsController extends FormBasicController { ...@@ -168,13 +166,7 @@ public class GroupsAndRightsController extends FormBasicController {
@Override @Override
protected void formInnerEvent(UserRequest ureq, FormItem source, FormEvent event) { protected void formInnerEvent(UserRequest ureq, FormItem source, FormEvent event) {
if(source instanceof FormLink && source.getUserObject() instanceof BGRightsOption) { if (source == removeAllLink) {
String name = source.getName();
if(name.startsWith("remove_")) {
BGRightsOption option = (BGRightsOption)source.getUserObject();
doRemoveRights(option);
}
} else if (source == removeAllLink) {
doRemoveAllRights(); doRemoveAllRights();
} else { } else {
super.formInnerEvent(ureq, source, event); super.formInnerEvent(ureq, source, event);
...@@ -239,17 +231,13 @@ public class GroupsAndRightsController extends FormBasicController { ...@@ -239,17 +231,13 @@ public class GroupsAndRightsController extends FormBasicController {
} }
} }
private void doRemoveRights(BGRightsOption option) {
rightManager.removeBGRights(option.getGroup(), resource, option.getRole());
}
private void doRemoveAllRights() { private void doRemoveAllRights() {
List<BusinessGroup> groups = getGroups(); List<BusinessGroup> groups = getGroups();
rightManager.removeBGRights(groups, resource); rightManager.removeBGRights(groups, resource);
loadModel(); loadModel();
} }
private class GroupsAndRightsDataModel extends DefaultTableDataModel<BGRightsOption> implements FlexiTableDataModel { private class GroupsAndRightsDataModel extends DefaultTableDataModel<BGRightsOption> implements FlexiTableDataModel<BGRightsOption> {
private FlexiTableColumnModel columnModel; private FlexiTableColumnModel columnModel;
public GroupsAndRightsDataModel(List<BGRightsOption> options, FlexiTableColumnModel columnModel) { public GroupsAndRightsDataModel(List<BGRightsOption> options, FlexiTableColumnModel columnModel) {
...@@ -284,8 +272,6 @@ public class GroupsAndRightsController extends FormBasicController { ...@@ -284,8 +272,6 @@ public class GroupsAndRightsController extends FormBasicController {
case participant: return translate("participant"); case participant: return translate("participant");
} }
return ""; return "";
} else if (col == (getColumnCount() - 1)) {
return groupRights.getRemoveLink();
} }
//rights //rights
...@@ -325,7 +311,6 @@ public class GroupsAndRightsController extends FormBasicController { ...@@ -325,7 +311,6 @@ public class GroupsAndRightsController extends FormBasicController {
private final BGRightsRole role; private final BGRightsRole role;
private List<BGRight> rightsEl; private List<BGRight> rightsEl;
private FormLink removeLink;
public BGRightsOption(BusinessGroup group, BGRightsRole role) { public BGRightsOption(BusinessGroup group, BGRightsRole role) {
this.group = group; this.group = group;
...@@ -365,13 +350,5 @@ public class GroupsAndRightsController extends FormBasicController { ...@@ -365,13 +350,5 @@ public class GroupsAndRightsController extends FormBasicController {
public void setRightsEl(List<BGRight> rightsEl) { public void setRightsEl(List<BGRight> rightsEl) {
this.rightsEl = rightsEl; this.rightsEl = rightsEl;
} }
public FormLink getRemoveLink() {
return removeLink;
}
public void setRemoveLink(FormLink removeLink) {
this.removeLink = removeLink;
}
} }
} }
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment