OO-2609: show the error message after catching the exceptions

src/main/java/org/olat/ims/qti21/QTI21Service.java

@@ -96,10 +96,12 @@ public interface QTI21Service {
 	
 	/**
 	 * Load the assessmentTest based on the imsmanifest.xml found in the resource
-	 * directory.
+	 * directory. Return null if the imsmanifest.xml is not found.
 	 * 
-	 * @param resourceDirectory
-	 * @return
+	 * @param resourceDirectory The directory where is the package
+	 * @param replace If true updates the cache
+	 * @param debugInfo If true writes more infos 
+	 * @return The resolved assessment test or null if the imsmanifest.xml was not found.
 	 */
 	public ResolvedAssessmentTest loadAndResolveAssessmentTest(File resourceDirectory, boolean replace, boolean debugInfo);
 	

src/main/java/org/olat/ims/qti21/manager/QTI21ServiceImpl.java

@@ -293,6 +293,9 @@ public class QTI21ServiceImpl implements QTI21Service, UserDataDeletable, Initia
 	@Override
 	public ResolvedAssessmentTest loadAndResolveAssessmentTest(File resourceDirectory, boolean replace, boolean debugInfo) {
         URI assessmentObjectSystemId = createAssessmentObjectUri(resourceDirectory);
+        if(assessmentObjectSystemId == null) {
+        	return null;
+        }
 		File resourceFile = new File(assessmentObjectSystemId);
 		if(replace) {
 			ResolvedAssessmentTest resolvedAssessmentTest = internalLoadAndResolveAssessmentTest(resourceDirectory, assessmentObjectSystemId);
@@ -367,17 +370,22 @@ public class QTI21ServiceImpl implements QTI21Service, UserDataDeletable, Initia
 	@Override
 	public URI createAssessmentObjectUri(final File resourceDirectory) {
 		final String key = resourceDirectory.getAbsolutePath();
-		return resourceToTestURI.computeIfAbsent(key, (directoryAbsolutPath) -> {
-			File manifestPath = new File(resourceDirectory, "imsmanifest.xml");
-			QTI21ContentPackage	cp = new QTI21ContentPackage(manifestPath.toPath());
-			try {
-				Path testPath = cp.getTest();
-				return testPath.toUri();
-			} catch (IOException e) {
-				log.error("", e);
-				return null;
-			}
-		});
+		try {
+			return resourceToTestURI.computeIfAbsent(key, (directoryAbsolutPath) -> {
+				File manifestPath = new File(resourceDirectory, "imsmanifest.xml");
+				QTI21ContentPackage	cp = new QTI21ContentPackage(manifestPath.toPath());
+				try {
+					Path testPath = cp.getTest();
+					return testPath.toUri();
+				} catch (IOException e) {
+					log.error("", e);
+					return null;
+				}
+			});
+		} catch (RuntimeException e) {
+			log.error("", e);
+			return null;
+		}
 	}
 
 	@Override

src/main/java/org/olat/ims/qti21/ui/AssessmentTestDisplayController.java

@@ -241,7 +241,7 @@ public class AssessmentTestDisplayController extends BasicController implements
 		FileResourceManager frm = FileResourceManager.getInstance();
 		fUnzippedDirRoot = frm.unzipFileResource(testEntry.getOlatResource());
 		resolvedAssessmentTest = qtiService.loadAndResolveAssessmentTest(fUnzippedDirRoot, false, false);
-		if(resolvedAssessmentTest.getRootNodeLookup().extractIfSuccessful() == null) {
+		if(resolvedAssessmentTest == null || resolvedAssessmentTest.getRootNodeLookup().extractIfSuccessful() == null) {
         	mainVC = createVelocityContainer("error");
 		} else {
 			currentRequestTimestamp = ureq.getRequestTimestamp();
@@ -269,10 +269,6 @@ public class AssessmentTestDisplayController extends BasicController implements
 		}
         
         mainPanel = putInitialPanel(mainVC);
-        
-        OLATResourceable sessionOres = OresHelper
-        		.createOLATResourceableInstance(AssessmentTestSession.class, candidateSession.getKey());
-        CoordinatorManager.getInstance().getCoordinator().getEventBus().registerFor(this, getIdentity(), sessionOres);
 	}
 	
 	private void immediateEndTestSession(UserRequest ureq) {