OO-456: guest cannot mark forum posts

src/main/java/org/olat/core/commons/services/mark/impl/ui/MarkController.java

@@ -103,6 +103,7 @@ public class MarkController extends FormBasicController {
 	protected void initForm(FormItemContainer formLayout, Controller listener, UserRequest ureq) {
 		markLink = uifactory.addFormLink("mark", " ", " ", formLayout, Link.NONTRANSLATED + Link.LINK_CUSTOM_CSS);
 		markLink.setCustomEnabledLinkCSS(marked ? "b_mark_set" : "b_mark_not_set");
+		markLink.setEnabled(!ureq.getUserSession().getRoles().isGuestOnly());
 
 		String tooltip;
 		if(stat == null) {

src/main/java/org/olat/modules/fo/FilterForUserController.java

@@ -406,11 +406,13 @@ public class FilterForUserController extends BasicController {
 		MarkResourceStat stat = stats.get(subPath);
 		MarkingService markingService = (MarkingService)CoreSpringFactory.getBean(MarkingService.class);
 		
-		String businessPath = currentMark == null ?
-				getWindowControl().getBusinessControl().getAsString() + "[Message:" + m.getKey() + "]"
-				: currentMark.getBusinessPath();
-		Controller markCtrl = markingService.getMarkController(ureq, getWindowControl(), currentMark, stat, forumOres, subPath, businessPath);
-		vcThreadView.put("mark_"+msgCount, markCtrl.getInitialComponent());
+		if(!ureq.getUserSession().getRoles().isGuestOnly()) {
+			String businessPath = currentMark == null ?
+					getWindowControl().getBusinessControl().getAsString() + "[Message:" + m.getKey() + "]"
+					: currentMark.getBusinessPath();
+			Controller markCtrl = markingService.getMarkController(ureq, getWindowControl(), currentMark, stat, forumOres, subPath, businessPath);
+			vcThreadView.put("mark_"+msgCount, markCtrl.getInitialComponent());
+		}
 		
 		map.put("modified", dateFormat.format(m.getLastModified()));
 		// message attachments

src/main/java/org/olat/modules/fo/ForumController.java

@@ -1181,15 +1181,17 @@ public class ForumController extends BasicController implements GenericEventList
 		MarkResourceStat stat = stats.get(subPath);
 		MarkingService markingService = (MarkingService)CoreSpringFactory.getBean(MarkingService.class);
 		
-		String businessPath = currentMark == null ?
-				getWindowControl().getBusinessControl().getAsString() + "[Message:" + m.getKey() + "]"
-				: currentMark.getBusinessPath();
-		Controller markCtrl = markingService.getMarkController(ureq, getWindowControl(), currentMark, stat, forumOres, subPath, businessPath);
-		vcThreadView.put("mark_"+msgCount, markCtrl.getInitialComponent());
+		if(!ureq.getUserSession().getRoles().isGuestOnly()) {
+			String businessPath = currentMark == null ?
+					getWindowControl().getBusinessControl().getAsString() + "[Message:" + m.getKey() + "]"
+					: currentMark.getBusinessPath();
+			Controller markCtrl = markingService.getMarkController(ureq, getWindowControl(), currentMark, stat, forumOres, subPath, businessPath);
+			vcThreadView.put("mark_"+msgCount, markCtrl.getInitialComponent());
+		}
 		
-		businessPath = BusinessControlFactory.getInstance().getAsString(getWindowControl().getBusinessControl()) + "[Message:" + m.getKey() + "]";
 		if (uIsMsgC) {
 			OLATResourceable messageOres = OresHelper.createOLATResourceableInstance("Forum", m.getKey());
+			String businessPath = BusinessControlFactory.getInstance().getAsString(getWindowControl().getBusinessControl()) + "[Message:" + m.getKey() + "]";
 			Controller ePFCollCtrl = EPUIFactory.createArtefactCollectWizzardController(ureq, getWindowControl(), messageOres,
 					businessPath);
 			if (ePFCollCtrl != null) {