OO-4254: fix duplicate ID on the login page

src/main/java/org/olat/gui/control/OlatDmzTopNavController.java

@@ -85,7 +85,7 @@ public class OlatDmzTopNavController extends BasicController implements Lockable
 			vc.put("topnav.browsercheck", browsercheckLink);
 		}
 		// about link
-		aboutLink = AboutController.aboutLinkFactory(getLocale(), this, true, false);
+		aboutLink = AboutController.aboutLinkFactory("top.menu.about", getLocale(), this, true, false);
 		aboutLink.setSuppressDirtyFormWarning(true);
 		vc.put("topnav.about", aboutLink);
 

src/main/java/org/olat/gui/control/OlatFooterController.java

@@ -130,7 +130,7 @@ public class OlatFooterController extends BasicController implements LockableCon
 		olatFootervc.contextPut("footerInfos", new FooterInformations(layoutModule));
 
 		// about link
-		aboutLink = AboutController.aboutLinkFactory(getLocale(), this, false, true);
+		aboutLink = AboutController.aboutLinkFactory("menu.about", getLocale(), this, false, true);
 		aboutLink.setCustomDisplayText(Settings.getApplicationName() + " " + Settings.getVersion());		
 		olatFootervc.put("aboutLink", aboutLink);
 		

src/main/java/org/olat/login/AboutController.java

@@ -126,10 +126,10 @@ public class AboutController extends BasicController {
 	 * @param withBuildInfo true: add build info to hover title (if available); false no build info
 	 * @return
 	 */
-	public static final Link aboutLinkFactory(Locale locale, Controller listener, boolean withIcon, boolean withBuildInfo) {
+	public static final Link aboutLinkFactory(String id, Locale locale, Controller listener, boolean withIcon, boolean withBuildInfo) {
 		Translator aboutTrans = Util.createPackageTranslator(AboutController.class, locale);
 		Link aboutLink = LinkFactory
-				.createLink("menu.about", "menu.about", "about", "menu.about", aboutTrans, null, listener, Link.LINK + Link.NONTRANSLATED);
+				.createLink(id, "menu.about", "about", "menu.about", aboutTrans, null, listener, Link.LINK + Link.NONTRANSLATED);
 		aboutLink.setCustomDisplayText(aboutTrans.translate("menu.about"));
 		if (withIcon) {			
 			aboutLink.setIconLeftCSS("o_icon o_icon_openolat o_icon-fw");