OO-144: rewrite the validate methods of to take in account the error of the text fields

--HG--
branch : 80-patch

src/main/java/org/olat/course/editor/NodeConfigFormController.java

@@ -26,7 +26,6 @@ import org.olat.core.gui.components.form.flexible.elements.RichTextElement;
 import org.olat.core.gui.components.form.flexible.elements.SingleSelection;
 import org.olat.core.gui.components.form.flexible.elements.TextElement;
 import org.olat.core.gui.components.form.flexible.impl.FormBasicController;
-import org.olat.core.gui.components.form.flexible.impl.FormEvent;
 import org.olat.core.gui.components.form.flexible.impl.FormLayoutContainer;
 import org.olat.core.gui.control.Controller;
 import org.olat.core.gui.control.Event;
@@ -181,6 +180,8 @@ public class NodeConfigFormController extends FormBasicController {
 			// the short title is mandatory
 			shortTitle.setErrorKey("nodeConfigForm.menumust", new String[] {});
 			shortTitleOk = false;
+		} else if (shortTitle.hasError()) {
+			shortTitleOk = false;
 		}
 		if (shortTitleOk && super.validateFormLogic(ureq)) {
 			shortTitle.clearError();

src/main/java/org/olat/repository/RepositoryEntryDetailsFormController.java

@@ -114,19 +114,25 @@ public class RepositoryEntryDetailsFormController extends FormBasicController {
 	@Override
 	protected boolean validateFormLogic(UserRequest ureq) {
 		// Check for empty display name
+		
+		boolean allOk = true;
 		if (!StringHelper.containsNonWhitespace(displayName.getValue())) {
 			displayName.setErrorKey("cif.error.displayname.empty", new String[] {});
-			return false;
+			allOk = false;
+		} else if (displayName.hasError()) {
+			allOk = false;
+		} else {
+			displayName.clearError();
 		}
-		displayName.clearError();
 		// Check for empty description
 		if (!StringHelper.containsNonWhitespace(description.getValue())) {
 			description.setErrorKey("cif.error.description.empty", new String[] {});
-			return false;
+			allOk = false;
+		} else {
+			description.clearError();
 		}
-		description.clearError();
 		// Ok, passed all checks
-		return super.validateFormLogic(ureq);
+		return allOk && super.validateFormLogic(ureq);
 	}
 
 	/**