OO-433,OO-441: optimize data retrieval, save default values of properties...

OO-433,OO-441: optimize data retrieval, save default values of properties which doesn't exist, check if the table controller is not disposed after loading start the data

src/main/java/org/olat/course/assessment/AssessmentMainController.java

@@ -442,7 +442,7 @@ AssessmentMainController(UserRequest ureq, WindowControl wControl, StackedContro
 					// cast should be save, only assessable nodes are selectable
 					if((repoTutor && coachedGroups.isEmpty()) || (callback.mayAssessAllUsers() || callback.mayViewAllUsersAssessments())) {
 						identitiesList = getAllAssessableIdentities();
-						doUserChooseWithData(ureq, this.identitiesList, null, currentCourseNode);
+						doUserChooseWithData(ureq, identitiesList, null, currentCourseNode);
 					} else {
 						doGroupChoose(ureq);
 					}
@@ -705,6 +705,12 @@ AssessmentMainController(UserRequest ureq, WindowControl wControl, StackedContro
 					localUserCourseEnvironmentCache, initialLaunchDates, course, courseNode);
 			wrappedIdentities.add(aiw);
 		}
+		
+		if(userListCtr == null) {
+			//takes too long -> controller disposed
+			return;
+		}
+		
 		// Add the wrapped identities to the table data model
 		AssessedIdentitiesTableDataModel tdm = new AssessedIdentitiesTableDataModel(wrappedIdentities, courseNode, ureq.getLocale(), isAdministrativeUser, mode == MODE_USERFOCUS);
 		tdm.addColumnDescriptors(userListCtr, CMD_CHOOSE_USER, mode == MODE_NODEFOCUS || mode == MODE_GROUPFOCUS || mode == MODE_USERFOCUS);

src/main/java/org/olat/course/assessment/NewCachePersistingAssessmentManager.java

@@ -247,6 +247,18 @@ public class NewCachePersistingAssessmentManager extends BasicManager implements
 				for (Property property:loadedProperties) {
 					addPropertyToCache(m, property);
 				}
+				
+				//If property not found, prefill with default value.
+				if(!m.containsKey(ATTEMPTS)) {
+					m.put(ATTEMPTS, INTEGER_ZERO);
+				}
+				if(!m.containsKey(SCORE)) {
+					m.put(SCORE, FLOAT_ZERO);
+				}
+				if(!m.containsKey(LAST_MODIFIED)) {
+					m.put(LAST_MODIFIED, null);
+				}
+				
 				// we use a putSilent here (no invalidation notifications to other cluster nodes), since
 				// we did not generate new data, but simply asked to reload it. 
 				if (prepareForNewData) {