OO-2259: save the abstract settings (attempts), validate max score...

src/main/java/org/olat/ims/qti21/ui/editor/MinimalScoreController.java

@@ -77,10 +77,21 @@ public class MinimalScoreController extends AssessmentItemRefEditorController {
 		uifactory.addFormSubmitButton("submit", buttonsContainer);
 	}
 
+	@Override
+	protected boolean validateFormLogic(UserRequest ureq) {
+		boolean allOk = true;
+		
+		allOk &= validateDouble(maxScoreEl);
+		
+		return allOk & super.validateFormLogic(ureq);
+	}
+
 	@Override
 	protected void formOK(UserRequest ureq) {
 		if(restrictedEdit) return;
 		
+		super.formOK(ureq);
+		
 		String maxScoreValue = maxScoreEl.getValue();
 		Double maxScore = Double.parseDouble(maxScoreValue);
 		itemBuilder.setMaxScore(maxScore);

src/main/java/org/olat/ims/qti21/ui/editor/interactions/AssessmentItemRefEditorController.java

@@ -105,6 +105,30 @@ public abstract class AssessmentItemRefEditorController extends FormBasicControl
 		return allOk & super.validateFormLogic(ureq);
 	}
 	
+	/**
+	 * This validate a mandatory double
+	 * @param el
+	 * @return
+	 */
+	protected boolean validateDouble(TextElement el) {
+		boolean allOk = true;
+		
+		String value = el.getValue();
+		el.clearError();
+		if(!StringHelper.containsNonWhitespace(value)) {
+			el.setErrorKey("form.legende.mandatory", null);
+			allOk &= false;
+		} else {
+			try {
+				Double.parseDouble(value);
+			} catch (NumberFormatException e) {
+				el.setErrorKey("error.double", null);
+				allOk &= false;
+			}
+		}
+		return allOk;
+	}
+	
 	@Override
 	protected void formInnerEvent(UserRequest ureq, FormItem source, FormEvent event) {
 		if(limitAttemptsEl == source) {

src/main/java/org/olat/ims/qti21/ui/editor/interactions/ChoiceScoreController.java

@@ -33,7 +33,6 @@ import org.olat.core.gui.components.form.flexible.impl.FormLayoutContainer;
 import org.olat.core.gui.control.Controller;
 import org.olat.core.gui.control.WindowControl;
 import org.olat.core.util.Formatter;
-import org.olat.core.util.StringHelper;
 import org.olat.core.util.Util;
 import org.olat.core.util.filter.FilterFactory;
 import org.olat.ims.qti21.model.xml.AssessmentHtmlBuilder;
@@ -184,24 +183,6 @@ public class ChoiceScoreController extends AssessmentItemRefEditorController imp
 		
 		return allOk & super.validateFormLogic(ureq);
 	}
-	
-	private boolean validateDouble(TextElement el) {
-		boolean allOk = true;
-		
-		String value = el.getValue();
-		if(!StringHelper.containsNonWhitespace(value)) {
-			el.setErrorKey("form.legende.mandatory", null);
-			allOk &= false;
-		} else {
-			try {
-				Double.parseDouble(value);
-			} catch (NumberFormatException e) {
-				el.setErrorKey("error.double", null);
-				allOk &= false;
-			}
-		}
-		return allOk;
-	}
 
 	@Override
 	protected void formInnerEvent(UserRequest ureq, FormItem source, FormEvent event) {

src/main/java/org/olat/ims/qti21/ui/editor/interactions/FIBScoreController.java

@@ -32,7 +32,6 @@ import org.olat.core.gui.components.form.flexible.impl.FormEvent;
 import org.olat.core.gui.components.form.flexible.impl.FormLayoutContainer;
 import org.olat.core.gui.control.Controller;
 import org.olat.core.gui.control.WindowControl;
-import org.olat.core.util.StringHelper;
 import org.olat.core.util.Util;
 import org.olat.ims.qti21.model.xml.AssessmentItemBuilder;
 import org.olat.ims.qti21.model.xml.ScoreBuilder;
@@ -177,24 +176,6 @@ public class FIBScoreController extends AssessmentItemRefEditorController implem
 		
 		return allOk & super.validateFormLogic(ureq);
 	}
-	
-	private boolean validateDouble(TextElement el) {
-		boolean allOk = true;
-		
-		String value = el.getValue();
-		if(!StringHelper.containsNonWhitespace(value)) {
-			el.setErrorKey("form.legende.mandatory", null);
-			allOk &= false;
-		} else {
-			try {
-				Double.parseDouble(value);
-			} catch (NumberFormatException e) {
-				el.setErrorKey("error.double", null);
-				allOk &= false;
-			}
-		}
-		return allOk;
-	}
 
 	@Override
 	protected void formInnerEvent(UserRequest ureq, FormItem source, FormEvent event) {
@@ -208,6 +189,7 @@ public class FIBScoreController extends AssessmentItemRefEditorController implem
 	protected void formOK(UserRequest ureq) {
 		if(restrictedEdit) return;
 		
+		super.formOK(ureq);
 		String maxScoreValue = maxScoreEl.getValue();
 		Double maxScore = Double.parseDouble(maxScoreValue);
 		itemBuilder.setMaxScore(maxScore);

src/main/java/org/olat/ims/qti21/ui/editor/interactions/HotspotChoiceScoreController.java

@@ -255,24 +255,6 @@ public class HotspotChoiceScoreController extends AssessmentItemRefEditorControl
 		
 		return allOk & super.validateFormLogic(ureq);
 	}
-	
-	private boolean validateDouble(TextElement el) {
-		boolean allOk = true;
-		
-		String value = el.getValue();
-		if(!StringHelper.containsNonWhitespace(value)) {
-			el.setErrorKey("form.legende.mandatory", null);
-			allOk &= false;
-		} else {
-			try {
-				Double.parseDouble(value);
-			} catch (NumberFormatException e) {
-				el.setErrorKey("error.double", null);
-				allOk &= false;
-			}
-		}
-		return allOk;
-	}
 
 	@Override
 	protected void formInnerEvent(UserRequest ureq, FormItem source, FormEvent event) {