OO-204: remove the magick path as it doesn't work

src/main/java/org/olat/core/util/_spring/utilCorecontext.xml

@@ -20,7 +20,5 @@
 
 	<bean id="imageHelperServiceProvider_java" class="org.olat.core.util.image.spi.ImageHelperImpl" />
 	
-	<bean id="imageHelperServiceProvider_magick" class="org.olat.core.util.image.spi.ImageMagickHelper">
-		<property name="magickPath" value="${thumbnail.magick.path}"/>
-	</bean>
+	<bean id="imageHelperServiceProvider_magick" class="org.olat.core.util.image.spi.ImageMagickHelper" />
 </beans>

src/main/java/org/olat/core/util/image/spi/ImageMagickHelper.java

@@ -47,19 +47,9 @@ import org.olat.core.util.vfs.VFSLeaf;
  */
 public class ImageMagickHelper extends BasicManager implements ImageHelperSPI {
 	
-	private String magickPath;
-	
 	public ImageMagickHelper() {
 		//
 	}
-	
-	/**
-	 * [used by Spring]
-	 * @param magickPath
-	 */
-	public void setMagickPath(String magickPath) {
-		this.magickPath = magickPath;
-	}
 
 	@Override
 	public Size thumbnailPDF(VFSLeaf pdfFile, VFSLeaf thumbnailFile, int maxWidth, int maxHeight) {
@@ -258,9 +248,7 @@ public class ImageMagickHelper extends BasicManager implements ImageHelperSPI {
 				}
 				
 				ProcessBuilder builder = new ProcessBuilder(cmd);
-				builder.environment().put("PATH", magickPath);
 				process = builder.start();
-				
 				size = executeProcess(thumbnailFile, process);
 				doneSignal.countDown();
 			} catch (IOException e) {

src/main/resources/serviceconfig/olat.properties

@@ -313,11 +313,9 @@ webdav.links.enabled=true
 ########################################################################
 thumbnail.provider=java
 # java is a pure java implementation (which use PDFBox too), magick use ImageMagick and
-# GhostScript
+# GhostScript. For the magick one, you must add the path to convert and gs command line
+# in your PATH environnment variable.
 thumbnail.provider.values=java,magick
-thumbnail.magick.path=/usr/local/bin/
-# path to ImageMagick and GhostScript executable ("convert") and GhostScript executable ("gs")
-thumbnail.provider.values=/usr/local/bin/
 
 ########################################################################
 # Shared resources - used only to generate sample configurations