OO-2870: add validation in the case min. score is bigger than max. score

src/main/java/org/olat/ims/qti21/ui/editor/_i18n/LocalStrings_de.properties

@@ -17,6 +17,7 @@ error.import.question=Die Frage konnte wegen eine unerwartete Fehler nicht impor
 error.lock=Dieser Test/Fragebogen wird momentan vom Benutzer {0} editiert und ist deshalb gesperrt.
 error.lock.title=Test gesperrt
 error.mimetype=$org.olat.core.commons.modules.bc\:WrongMimeType
+error.min.score.bigger.max=Minimal erreichbare Punktzahl muss kleiner als then maximal erreichbare Punktzahl sein.
 error.need.correct.answer=Sie m\u00FCssen mindestens eine Antwort als korrekt markieren.
 error.positive.double=Falsches Zahlenformat, nur positive Nummer sind erlaubt. Beispiele\: 15.0, 5.5, 10
 error.singlechoice=Genau ein ausw\u00E4hlen

src/main/java/org/olat/ims/qti21/ui/editor/_i18n/LocalStrings_en.properties

@@ -17,6 +17,7 @@ error.positive.double=Only positive number are allowed. Example\: 15.0, 5.5, 10
 error.import.question=An unexpected error happens during import of a question.
 error.lock=This test/questionnaire is being edited by user {0} at the moment and therefore locked.
 error.lock.title=Test locked
+error.min.score.bigger.max=Min. score must be bigger than the max. score.
 error.mimetype=$org.olat.core.commons.modules.bc\:WrongMimeType
 error.missing.fib=The question need at least a gap text or a numerical input.
 error.missing.hottext=The question need at least a hottext.

src/main/java/org/olat/ims/qti21/ui/editor/interactions/AssessmentItemRefEditorController.java

@@ -130,6 +130,23 @@ public abstract class AssessmentItemRefEditorController extends FormBasicControl
 		return allOk;
 	}
 	
+	protected boolean validateMinMaxScores(TextElement minScoreEl, TextElement maxScoreEl) {
+		boolean allOk = true;
+		allOk &= validateDouble(minScoreEl);
+		allOk &= validateDouble(maxScoreEl);
+		
+		if(allOk) {
+			double minScore =Double.parseDouble(minScoreEl.getValue());
+			double maxScore = Double.parseDouble(maxScoreEl.getValue());
+			if(minScore > maxScore) {
+				minScoreEl.setErrorKey("error.min.score.bigger.max", null);
+				allOk &= false;
+			}
+		}
+		
+		return allOk;
+	}
+	
 	@Override
 	protected void formInnerEvent(UserRequest ureq, FormItem source, FormEvent event) {
 		if(limitAttemptsEl == source) {

src/main/java/org/olat/ims/qti21/ui/editor/interactions/ChoiceScoreController.java

@@ -195,8 +195,7 @@ public class ChoiceScoreController extends AssessmentItemRefEditorController imp
 	@Override
 	protected boolean validateFormLogic(UserRequest ureq) {
 		boolean allOk = true;
-		allOk &= validateDouble(maxScoreEl);
-		allOk &= validateDouble(minScoreEl);
+		allOk &= validateMinMaxScores(minScoreEl, maxScoreEl);
 
 		if(assessmentModeEl.isOneSelected() && assessmentModeEl.isSelected(1)) {
 			for(ChoiceWrapper wrapper:wrappers) {

src/main/java/org/olat/ims/qti21/ui/editor/interactions/HotspotChoiceScoreController.java

@@ -243,8 +243,7 @@ public class HotspotChoiceScoreController extends AssessmentItemRefEditorControl
 	@Override
 	protected boolean validateFormLogic(UserRequest ureq) {
 		boolean allOk = true;
-		allOk &= validateDouble(maxScoreEl);
-		allOk &= validateDouble(minScoreEl);
+		allOk &= validateMinMaxScores(minScoreEl, maxScoreEl);
 
 		if(assessmentModeEl.isOneSelected() && assessmentModeEl.isSelected(1)) {
 			for(HotspotChoiceWrapper wrapper:wrappers) {

src/main/java/org/olat/ims/qti21/ui/editor/interactions/MatchScoreController.java

@@ -215,8 +215,7 @@ public class MatchScoreController extends AssessmentItemRefEditorController impl
 	@Override
 	protected boolean validateFormLogic(UserRequest ureq) {
 		boolean allOk = true;
-		allOk &= validateDouble(maxScoreEl);
-		allOk &= validateDouble(minScoreEl);
+		allOk &= validateMinMaxScores(minScoreEl, maxScoreEl);
 
 		if(assessmentModeEl.isOneSelected() && assessmentModeEl.isSelected(1)) {
 			for(Map.Entry<DirectedPairValue, MatchScoreWrapper> entry:scoreWrappers.entrySet()) {