Skip to content
Snippets Groups Projects
Commit 5f86bfa6 authored by uhensler's avatar uhensler
Browse files

Merge branch 'OpenOLAT_14.2' into OpenOLAT_15.0

parents a1fa313d 48aea7d8
No related branches found
No related tags found
No related merge requests found
......@@ -209,7 +209,9 @@ public class VFSTrashController extends FormBasicController implements ProgressD
private void doDelete(List<VersionsDeletedFileRow> rowsToDelete) {
for(VersionsDeletedFileRow row:rowsToDelete) {
VFSRevision revision = vfsRepositoryService.getRevision(new VFSRevisionRefImpl(row.getRevisionKey()));
doDelete(revision);
if(revision != null) {
doDelete(revision);
}
}
}
......
......@@ -351,9 +351,9 @@ public class AssessmentNotificationsHandler implements NotificationsHandler {
for (CourseNode test:testNodes) {
List<AssessmentEntry> assessments = courseNodeAssessmentDao.loadAssessmentEntryBySubIdent(cgm.getCourseEntry(), test.getIdent());
for(AssessmentEntry assessment:assessments) {
Date modDate = assessment.getLastModified();
Date modDate = getLater(assessment.getLastUserModified(), assessment.getLastCoachModified());
Identity assessedIdentity = assessment.getIdentity();
if (modDate.after(compareDate) && (hasFullAccess || coachedUsers.contains(assessedIdentity))) {
if (modDate != null && modDate.after(compareDate) && (hasFullAccess || coachedUsers.contains(assessedIdentity))) {
BigDecimal score = assessment.getScore();
if(test instanceof ScormCourseNode) {
ScormCourseNode scormTest = (ScormCourseNode)test;
......@@ -405,6 +405,13 @@ public class AssessmentNotificationsHandler implements NotificationsHandler {
}
}
private Date getLater(Date date1, Date date2) {
if (date1 == null) return date2;
if (date2 == null) return date1;
return date1.after(date2)? date1: date2;
}
private void checkPublisher(Publisher p) {
try {
if(!NotificationsUpgradeHelper.checkCourse(p)) {
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment