Skip to content
Snippets Groups Projects
Commit 57bf9181 authored by uhensler's avatar uhensler
Browse files

OO-4186: More consistent method name

parent 2b51d194
No related branches found
No related tags found
No related merge requests found
Showing
with 18 additions and 18 deletions
......@@ -163,7 +163,7 @@ public class AssessmentHelper {
if (assessmentConfig.hasAttempts()) {
attempts = courseAssessmentService.getUserAttempts(courseNode, uce);
}
if (assessmentConfig.hasDetails()) {
if (assessmentConfig.hasEditableDetails()) {
details = courseNode.getDetailsListView(uce);
if (details == null) {
details = DETAILS_NA_VALUE;
......@@ -402,7 +402,7 @@ public class AssessmentHelper {
if (courseNode instanceof AssessableCourseNode && !(courseNode instanceof ProjectBrokerCourseNode)) {
CourseAssessmentService courseAssessmentService = CoreSpringFactory.getImpl(CourseAssessmentService.class);
AssessmentConfig assessmentConfig = courseAssessmentService.getAssessmentConfig(courseNode);
if (assessmentConfig.hasDetails()
if (assessmentConfig.hasEditableDetails()
|| assessmentConfig.hasAttempts()
|| assessmentConfig.hasScore()
|| assessmentConfig.hasPassed()
......@@ -515,7 +515,7 @@ public class AssessmentHelper {
if(!followUserVisibility || scoreEvaluation.getUserVisible() == null || scoreEvaluation.getUserVisible().booleanValue()) {
// details
if (assessmentConfig.hasDetails()) {
if (assessmentConfig.hasEditableDetails()) {
hasDisplayableValuesConfigured = true;
String detailValue = assessableCourseNode.getDetailsListView(userCourseEnv);
if (detailValue == null) {
......
......@@ -90,8 +90,8 @@ public interface AssessmentConfig {
public boolean isEditable();
/**
* @return True if this course node has additional details to be edited / viewed
* @return True if this course node has additional details to be edited.
*/
public boolean hasDetails();
public boolean hasEditableDetails();
}
......@@ -40,7 +40,7 @@ public interface AssessmentHandler {
/**
* Returns a controller to edit the node specific details. Check
* AssessmentConfig.hasDeatils() before invoking this method.
* AssessmentConfig.hasEditableDetails() before invoking this method.
*
* @param ureq
* @param wControl
......
......@@ -98,7 +98,7 @@ public class NonAssessmentConfig implements AssessmentConfig {
}
@Override
public boolean hasDetails() {
public boolean hasEditableDetails() {
return false;
}
......
......@@ -127,7 +127,7 @@ public class AssessmentIdentityCourseNodeController extends BasicController impl
// Add the users details controller
AssessmentConfig assessmentConfig = courseAssessmentService.getAssessmentConfig(courseNode);
if (assessmentConfig.hasDetails() && courseNodeDetails) {
if (assessmentConfig.hasEditableDetails() && courseNodeDetails) {
detailsEditController = courseAssessmentService.getAssessmentHandler(aCourseNode)
.getDetailsEditController(ureq, wControl, stackPanel, courseNode, coachCourseEnv,
assessedUserCourseEnvironment);
......
......@@ -116,7 +116,7 @@ public class LTIAssessmentConfig implements AssessmentConfig {
}
@Override
public boolean hasDetails() {
public boolean hasEditableDetails() {
// having score defined means the node is assessable
return config.getBooleanSafe(MSCourseNode.CONFIG_KEY_HAS_SCORE_FIELD);
}
......
......@@ -50,7 +50,7 @@ public class CheckListAssessmentConfig extends ModuleAssessmentConfig {
}
@Override
public boolean hasDetails() {
public boolean hasEditableDetails() {
return true;
}
......
......@@ -87,7 +87,7 @@ public class GTAAssessmentConfig extends ModuleAssessmentConfig {
}
@Override
public boolean hasDetails() {
public boolean hasEditableDetails() {
return config.getBooleanSafe(GTACourseNode.GTASK_ASSIGNMENT)
|| config.getBooleanSafe(GTACourseNode.GTASK_SUBMIT)
|| config.getBooleanSafe(GTACourseNode.GTASK_REVIEW_AND_CORRECTION)
......
......@@ -168,7 +168,7 @@ public class IQTESTAssessmentConfig implements AssessmentConfig {
}
@Override
public boolean hasDetails() {
public boolean hasEditableDetails() {
return true;
}
......
......@@ -75,7 +75,7 @@ public class MSAssessmentConfig extends ModuleAssessmentConfig {
}
@Override
public boolean hasDetails() {
public boolean hasEditableDetails() {
return config.getBooleanSafe(MSCourseNode.CONFIG_KEY_EVAL_FORM_ENABLED);
}
......
......@@ -50,7 +50,7 @@ public class PortfolioAssessmentConfig extends ModuleAssessmentConfig {
}
@Override
public boolean hasDetails() {
public boolean hasEditableDetails() {
return true;
}
......
......@@ -71,7 +71,7 @@ public class ProjectBrokerAssessmentConfig extends ModuleAssessmentConfig {
}
@Override
public boolean hasDetails() {
public boolean hasEditableDetails() {
return config.getBooleanSafe(ProjectBrokerCourseNode.CONF_DROPBOX_ENABLED);
}
......
......@@ -106,7 +106,7 @@ public class ScormAssessmentConfig implements AssessmentConfig {
}
@Override
public boolean hasDetails() {
public boolean hasEditableDetails() {
return config.getBooleanSafe(ScormEditController.CONFIG_ISASSESSABLE, true);
}
......
......@@ -106,7 +106,7 @@ public class STAssessmentConfig implements AssessmentConfig {
}
@Override
public boolean hasDetails() {
public boolean hasEditableDetails() {
return false;
}
}
......@@ -80,7 +80,7 @@ public class TAAssessmentConfig extends ModuleAssessmentConfig {
}
@Override
public boolean hasDetails() {
public boolean hasEditableDetails() {
return config.getBooleanSafe(TACourseNode.CONF_TASK_ENABLED)
|| config.getBooleanSafe(TACourseNode.CONF_DROPBOX_ENABLED)
|| config.getBooleanSafe(TACourseNode.CONF_RETURNBOX_ENABLED);
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment