FXOLAT-193 backport from OLAT-6163 remove links / show error where possible

--HG--
branch : uzhFixes711

olat3/webapp/WEB-INF/src/org/olat/NewControllerFactory.java

@@ -100,6 +100,20 @@ public class NewControllerFactory extends LogDelegator {
 		return contextEntryControllerCreators.containsKey(key);
 	}
 
+	/**
+	 * Check first context entry can be launched
+	 * a further check is mostly not possible, as it gets validated through the BC-stack while building the controller-chain
+	 * 
+	 * return true: if this will be launchable at least for the first step.
+	 */
+	public boolean validateCEWithContextControllerCreator(final UserRequest ureq, final WindowControl wControl, ContextEntry ce){
+		String firstType = ce.getOLATResourceable().getResourceableTypeName();
+		if (canLaunch(firstType)){
+			return contextEntryControllerCreators.get(firstType).validateContextEntryAndShowError(ce, ureq, wControl);
+		}
+		return false;
+	}
+
 	/**
 	 * Launch a controller in a tab or site in the given window from a user
 	 * request url

olat3/webapp/WEB-INF/src/org/olat/modules/fo/ForumController.java

@@ -303,7 +303,8 @@ public class ForumController extends BasicController implements GenericEventList
 					scrollToCurrentMessage();					
 				} else {
 					// message not found, do nothing. Load normal start screen
-					logDebug("Invalid messageId=" , ores.getResourceableId().toString());
+					showError("deleteok");
+					logDebug("Invalid messageId=", ores.getResourceableId().toString());
 				}
 			} else {
 				//FIXME:chg: Should not happen, occurs when course-node are called

olat3/webapp/WEB-INF/src/org/olat/modules/wiki/WikiMainController.java

@@ -172,7 +172,10 @@ public class WikiMainController extends BasicController implements CloneableCont
 		ThreadLocalUserActivityLogger.log(LearningResourceLoggingAction.LEARNING_RESOURCE_OPEN, getClass());
 		// init the first page either startpage or an other page identified by initial page name
 		if (initialPageName != null && wiki.pageExists(WikiManager.generatePageId(initialPageName))) page = wiki.getPage(initialPageName, true);
-		else page = wiki.getPage(WikiPage.WIKI_INDEX_PAGE);
+		else {
+			page = wiki.getPage(WikiPage.WIKI_INDEX_PAGE);
+			if (initialPageName != null) showError("wiki.error.page.not.found");
+		}
 		this.pageId = page.getPageId();
 		
 		WikiPage menuPage = getWiki().getPage(WikiPage.WIKI_MENU_PAGE);

olat3/webapp/WEB-INF/src/org/olat/portfolio/ui/artefacts/view/EPArtefactViewController.java

@@ -26,6 +26,7 @@ import java.util.Iterator;
 import java.util.List;
 import java.util.Map;
 
+import org.olat.NewControllerFactory;
 import org.olat.core.CoreSpringFactory;
 import org.olat.core.gui.UserRequest;
 import org.olat.core.gui.components.Component;
@@ -211,7 +212,7 @@ public class EPArtefactViewController extends FormBasicController {
 
 		// build link to original source
 		if (StringHelper.containsNonWhitespace(artefact.getBusinessPath())) {
-			String sourceLink = createLinkToArtefactSource(artefact.getBusinessPath());
+			String sourceLink = createLinkToArtefactSource(ureq, artefact.getBusinessPath());
 			flc.contextPut("artefactSourceLink", sourceLink);			
 		}
 		
@@ -267,11 +268,12 @@ public class EPArtefactViewController extends FormBasicController {
 		return busLink;
 	}
 
-	private String createLinkToArtefactSource(String businessPath){
+	private String createLinkToArtefactSource(UserRequest ureq, String businessPath){
 		BusinessControlFactory bCF = BusinessControlFactory.getInstance(); 
 		List<ContextEntry> ceList = bCF.createCEListFromString(businessPath);
+		boolean valid = NewControllerFactory.getInstance().validateCEWithContextControllerCreator(ureq, getWindowControl(), ceList.get(0));
 		String busLink = bCF.getAsURIString(ceList, true); 
-		if (StringHelper.containsNonWhitespace(busLink)){
+		if (valid && StringHelper.containsNonWhitespace(busLink)){
 			return "<a href=\"" + busLink + "\">" + translate("artefact.open.source") + "</a>";
 		} else return translate("artefact.no.source");
 	}