no-jira: hardened selenium for Firefox

src/test/java/org/olat/ldap/LDAPLoginTest.java

@@ -19,7 +19,6 @@
  */
 package org.olat.ldap;
 
-import javax.naming.NamingException;
 import javax.naming.directory.Attributes;
 import javax.naming.ldap.LdapContext;
 
@@ -68,7 +67,7 @@ public class LDAPLoginTest extends OlatTestCase {
 	}
 	
 	@Test
-	public void testUserBind() throws NamingException {
+	public void testUserBind() throws Exception {
 		Assume.assumeTrue(ldapLoginModule.isLDAPEnabled());
 
 		LDAPError errors = new LDAPError();

src/test/java/org/olat/selenium/page/core/ContactPage.java

@@ -56,6 +56,7 @@ public class ContactPage {
 		browser.findElement(subjectBy).sendKeys(subject);
 		
 		String containerCssSelector = "div.o_sel_contact_body";
+		OOGraphene.waitTinymce(browser);
 		OOGraphene.tinymce(body, containerCssSelector, browser);
 		return this;
 	}

src/test/java/org/olat/selenium/page/repository/AuthoringEnvPage.java

@@ -42,6 +42,7 @@ public class AuthoringEnvPage {
 	
 	public static final By createMenuCaretBy = By.cssSelector("a.o_sel_author_create");
 	public static final By createMenuBy = By.cssSelector("ul.o_sel_author_create");
+	public static final By generaltabBy = By.className("o_sel_edit_repositoryentry");
 	
 	private WebDriver browser;
 	
@@ -135,7 +136,8 @@ public class AuthoringEnvPage {
 		browser.findElement(submitBy).click();
 		OOGraphene.waitBusy(browser);
 		OOGraphene.waitModalDialogDisappears(browser);
-		OOGraphene.waitElement(RepositoryEditDescriptionPage.generaltabBy, browser);
+		OOGraphene.waitElement(generaltabBy, browser);
+		OOGraphene.waitTinymce(browser);
 		return new RepositorySettingsPage(browser);
 	}
 	
@@ -197,7 +199,7 @@ public class AuthoringEnvPage {
 			saveButton.click();
 			OOGraphene.waitBusy(browser);
 			OOGraphene.waitModalDialogDisappears(browser);
-			OOGraphene.waitElement(RepositoryEditDescriptionPage.generaltabBy, browser);
+			OOGraphene.waitElement(generaltabBy, browser);
 			OOGraphene.waitTinymce(browser);
 		}
 		return this;

src/test/java/org/olat/selenium/page/repository/RepositoryEditDescriptionPage.java

@@ -20,7 +20,6 @@
 package org.olat.selenium.page.repository;
 
 import org.olat.selenium.page.graphene.OOGraphene;
-import org.openqa.selenium.By;
 import org.openqa.selenium.WebDriver;
 
 /**
@@ -32,8 +31,6 @@ import org.openqa.selenium.WebDriver;
  *
  */
 public class RepositoryEditDescriptionPage {
-	
-	public static final By generaltabBy = By.className("o_sel_edit_repositoryentry");
 
 	private final WebDriver browser;
 	

src/test/java/org/olat/selenium/page/taxonomy/TaxonomyTreePage.java

@@ -52,6 +52,9 @@ public class TaxonomyTreePage {
 	 * @return Itself
 	 */
 	public TaxonomyTreePage atLeastOneLevel(String identifier, String name) {
+		By tableTreeBy = By.cssSelector("div.o_sel_taxonomy_levels_tree table");
+		OOGraphene.waitElement(tableTreeBy, browser);
+		
 		By tableBy = By.xpath("//div[contains(@class,'o_sel_taxonomy_levels_tree')]//table//tr/td[text()[contains(.,'" + identifier + "')]]");
 		List<WebElement> tableEls = browser.findElements(tableBy);
 		if(tableEls.isEmpty()) {
@@ -83,6 +86,7 @@ public class TaxonomyTreePage {
 		
 		By identifierBy = By.cssSelector("div.o_sel_taxonomy_level_identifier input[type='text']");
 		OOGraphene.waitElement(identifierBy, browser);
+		OOGraphene.waitTinymce(browser);// to be nice to firefox
 		browser.findElement(identifierBy).sendKeys(identifier);
 		
 		By nameBy = By.cssSelector("div.o_sel_taxonomy_level_name input[type='text']");
@@ -92,6 +96,10 @@ public class TaxonomyTreePage {
 		browser.findElement(saveBy).click();
 		OOGraphene.waitBusy(browser);
 		OOGraphene.waitModalDialogDisappears(browser);
+		
+		// wait update in the table
+		By editTabsBy = By.className("o_sel_taxonomy_level_tabs");
+		OOGraphene.waitElement(editTabsBy, browser);
 		return this;
 	}