Skip to content
Snippets Groups Projects
Commit 3991fafc authored by srosse's avatar srosse
Browse files

OO-1291: fix user search by OAuth account

parent f6280551
No related branches found
No related tags found
No related merge requests found
...@@ -94,12 +94,15 @@ import org.olat.core.util.mail.ContactMessage; ...@@ -94,12 +94,15 @@ import org.olat.core.util.mail.ContactMessage;
import org.olat.core.util.resource.OresHelper; import org.olat.core.util.resource.OresHelper;
import org.olat.login.LoginModule; import org.olat.login.LoginModule;
import org.olat.login.auth.AuthenticationProvider; import org.olat.login.auth.AuthenticationProvider;
import org.olat.login.oauth.OAuthLoginModule;
import org.olat.login.oauth.OAuthSPI;
import org.olat.modules.co.ContactFormController; import org.olat.modules.co.ContactFormController;
import org.olat.user.UserInfoMainController; import org.olat.user.UserInfoMainController;
import org.olat.user.UserManager; import org.olat.user.UserManager;
import org.olat.user.propertyhandlers.EmailProperty; import org.olat.user.propertyhandlers.EmailProperty;
import org.olat.user.propertyhandlers.UserPropertyHandler; import org.olat.user.propertyhandlers.UserPropertyHandler;
import org.olat.util.logging.activity.LoggingResourceable; import org.olat.util.logging.activity.LoggingResourceable;
import org.springframework.beans.factory.annotation.Autowired;
/** /**
* Initial Date: Jan 31, 2006 * Initial Date: Jan 31, 2006
...@@ -134,7 +137,9 @@ public class UsermanagerUserSearchController extends BasicController implements ...@@ -134,7 +137,9 @@ public class UsermanagerUserSearchController extends BasicController implements
private boolean showEmailButton = true; private boolean showEmailButton = true;
private StepsMainRunController userBulkChangeStepsController; private StepsMainRunController userBulkChangeStepsController;
private final boolean isAdministrativeUser; private final boolean isAdministrativeUser;
private final BaseSecurityModule securityModule;
@Autowired
private BaseSecurityModule securityModule;
/** /**
* Constructor to trigger the user search workflow using a generic search form * Constructor to trigger the user search workflow using a generic search form
...@@ -145,7 +150,6 @@ public class UsermanagerUserSearchController extends BasicController implements ...@@ -145,7 +150,6 @@ public class UsermanagerUserSearchController extends BasicController implements
public UsermanagerUserSearchController(UserRequest ureq, WindowControl wControl) { public UsermanagerUserSearchController(UserRequest ureq, WindowControl wControl) {
super(ureq, wControl); super(ureq, wControl);
securityModule = CoreSpringFactory.getImpl(BaseSecurityModule.class);
isAdministrativeUser = securityModule.isUserAllowedAdminProps(ureq.getUserSession().getRoles()); isAdministrativeUser = securityModule.isUserAllowedAdminProps(ureq.getUserSession().getRoles());
userSearchVC = createVelocityContainer("usermanagerUsersearch"); userSearchVC = createVelocityContainer("usermanagerUsersearch");
...@@ -642,6 +646,10 @@ class UsermanagerUserSearchForm extends FormBasicController { ...@@ -642,6 +646,10 @@ class UsermanagerUserSearchForm extends FormBasicController {
private Map <String,FormItem>items; private Map <String,FormItem>items;
private final boolean isAdministrativeUser; private final boolean isAdministrativeUser;
@Autowired
private OAuthLoginModule oauthLoginModule;
/** /**
* @param binderName * @param binderName
* @param cancelbutton * @param cancelbutton
...@@ -770,10 +778,16 @@ class UsermanagerUserSearchForm extends FormBasicController { ...@@ -770,10 +778,16 @@ class UsermanagerUserSearchForm extends FormBasicController {
List<String> apl = new ArrayList<String>(); List<String> apl = new ArrayList<String>();
for (int i=0; i<authKeys.length; i++) { for (int i=0; i<authKeys.length; i++) {
if (auth.isSelected(i)) { if (auth.isSelected(i)) {
if("noAuth".equals(authKeys[i])) { String authKey = authKeys[i];
if("noAuth".equals(authKey)) {
apl.add(null);//special case apl.add(null);//special case
} else if("OAuth".equals(authKey)) {
List<OAuthSPI> spis = oauthLoginModule.getAllSPIs();
for(OAuthSPI spi:spis) {
apl.add(spi.getProviderName());
}
} else { } else {
apl.add(authKeys[i]); apl.add(authKey);
} }
} }
} }
......
...@@ -118,6 +118,10 @@ public class OAuthLoginModule extends AbstractSpringModule { ...@@ -118,6 +118,10 @@ public class OAuthLoginModule extends AbstractSpringModule {
adfsOAuth2Endpoint = getStringPropertyValue("adfsOAuth2Endpoint", false); adfsOAuth2Endpoint = getStringPropertyValue("adfsOAuth2Endpoint", false);
} }
public List<OAuthSPI> getAllSPIs() {
return new ArrayList<>(oauthSPIs);
}
public List<OAuthSPI> getEnableSPIs() { public List<OAuthSPI> getEnableSPIs() {
List<OAuthSPI> enabledSpis = new ArrayList<>(); List<OAuthSPI> enabledSpis = new ArrayList<>();
if(oauthSPIs != null) { if(oauthSPIs != null) {
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment