Commit 1a916b2c authored by User expired's avatar User expired
Browse files

trying to harmonize selenium browsers (FF, chrome & phantomjs)

parent 6b655222
Upcoming version:
-----------------
- trying to harmonize selenium browsers (FF, chrome & phantomjs) (Nikolaus Krismer)
- trying to fix selenium's WebDriverException (Nikolaus Krismer)
- improved repo order (Nikolaus Krismer)
- Fixed dependency problems (with geotools 17.2) (Nikolaus Krismer)
......
......@@ -106,14 +106,13 @@ public final class SeleniumDriver implements AutoCloseable {
@Override
public void close() {
// Closing the session before quitting does not work anymore on selenium 3.4 (tested with geckodriver 0.16.1)
// -> this would lead to a WebDriverException (tried to run command without establishing a connection)
// for (final String handle : driver.getWindowHandles()) {
// // closing all tabs before quitting should not be needed
// // -> since we had some issues with "ghost-processes" multiple times now, we leave this here to be (more) sure
// driver.switchTo().window(handle);
// driver.close();
// }
for (final String handle : driver.getWindowHandles()) {
// closing all tabs before quitting should not be needed
// -> since we had some issues with "ghost-processes" multiple times now, we leave this here to be (more) sure
// however, if problems occur (WebDriverException) try to deactivate this first
driver.switchTo().window(handle);
driver.close();
}
driver.quit();
}
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment