diff --git a/src/main/java/org/olat/course/assessment/CourseAssessmentService.java b/src/main/java/org/olat/course/assessment/CourseAssessmentService.java index 377d6089cdecab905a4a9b6dbb9738401f123c01..7752af750e8550bc9980bff52ddfaa8cc9de9f16 100644 --- a/src/main/java/org/olat/course/assessment/CourseAssessmentService.java +++ b/src/main/java/org/olat/course/assessment/CourseAssessmentService.java @@ -56,7 +56,7 @@ public interface CourseAssessmentService { /** * Returns the persisted AssessmentEntry of the user. Check - * AssessmentConfig.isScoreEvaluationPersisted() before invoking this method. + * AssessmentConfig.isEvaluationPersisted() before invoking this method. * * @param courseNode * @param userCourseEnvironment @@ -120,7 +120,7 @@ public interface CourseAssessmentService { /** * Returns the ScoreCalculator if the course nod can calculate its score. Check - * AssessmentConfig.isScoreEvaluationCalculated() before invoking this method. + * AssessmentConfig.isEvaluationCalculated() before invoking this method. * * @param courseNode * @return diff --git a/src/main/java/org/olat/course/assessment/handler/AssessmentConfig.java b/src/main/java/org/olat/course/assessment/handler/AssessmentConfig.java index 7e35c0b4da1a42d8b1f57a82c815f0e3e8481970..35492325763147935987ceb2aae6315157db074b 100644 --- a/src/main/java/org/olat/course/assessment/handler/AssessmentConfig.java +++ b/src/main/java/org/olat/course/assessment/handler/AssessmentConfig.java @@ -35,14 +35,14 @@ public interface AssessmentConfig { public boolean isAssessable(); /** - * @return true if the score evaluation is persisted + * @return true if the assessment evaluation is persisted */ - public boolean isScoreEvaluationPersisted(); + public boolean isEvaluationPersisted(); /** * @return true if the score evaluation is calculated e.g as sum of other assessments. */ - public boolean isScoreEvaluationCalculated(); + public boolean isEvaluationCalculated(); /** * @return True if this course node produces a score variable for the learner diff --git a/src/main/java/org/olat/course/assessment/handler/AssessmentHandler.java b/src/main/java/org/olat/course/assessment/handler/AssessmentHandler.java index ee63f7eaf45fbc5072a064d0cffd9d284327e80f..056ba8e38d6a604d2c1951f363153484de0b365d 100644 --- a/src/main/java/org/olat/course/assessment/handler/AssessmentHandler.java +++ b/src/main/java/org/olat/course/assessment/handler/AssessmentHandler.java @@ -51,7 +51,7 @@ public interface AssessmentHandler { public AssessmentConfig getAssessmentConfig(CourseNode courseNode); /** - * This method has to be implemented if the AssessmentConfig.isScoreEvaluationPersisted() return true. + * This method has to be implemented if the AssessmentConfig.isEvaluationPersisted() return true. * * @param courseNode * @param userCourseEnvironment @@ -60,7 +60,7 @@ public interface AssessmentHandler { public AssessmentEntry getAssessmentEntry(CourseNode courseNode, UserCourseEnvironment userCourseEnvironment); /** - * This method has to be implemented if the AssessmentConfig.isScoreEvaluationCalculated() return true. + * This method has to be implemented if the AssessmentConfig.isEvaluationCalculated() return true. * * @param courseNode * @param userCourseEnvironment @@ -69,7 +69,7 @@ public interface AssessmentHandler { public AssessmentEvaluation getCalculatedScoreEvaluation(CourseNode courseNode, UserCourseEnvironment userCourseEnvironment); /** - * This method has to be implemented if the AssessmentConfig.isScoreEvaluationCalculated() return true. + * This method has to be implemented if the AssessmentConfig.isEvaluationCalculated() return true. * * @param courseNode * @param userCourseEnvironment diff --git a/src/main/java/org/olat/course/assessment/handler/ModuleAssessmentConfig.java b/src/main/java/org/olat/course/assessment/handler/ModuleAssessmentConfig.java index c7ee34a9a671cea305cc0ef397c865405cef4f5f..ce59e6d54cadce324622878f0a88670cf4a1107e 100644 --- a/src/main/java/org/olat/course/assessment/handler/ModuleAssessmentConfig.java +++ b/src/main/java/org/olat/course/assessment/handler/ModuleAssessmentConfig.java @@ -43,12 +43,12 @@ public abstract class ModuleAssessmentConfig implements AssessmentConfig { } @Override - public boolean isScoreEvaluationPersisted() { + public boolean isEvaluationPersisted() { return true; } @Override - public boolean isScoreEvaluationCalculated() { + public boolean isEvaluationCalculated() { return false; } diff --git a/src/main/java/org/olat/course/assessment/handler/NonAssessmentConfig.java b/src/main/java/org/olat/course/assessment/handler/NonAssessmentConfig.java index 3b44d38c0e3c97761b0a1984c7e39c1467be0159..be804e517880f0576fce724335f00fdbfafa29b3 100644 --- a/src/main/java/org/olat/course/assessment/handler/NonAssessmentConfig.java +++ b/src/main/java/org/olat/course/assessment/handler/NonAssessmentConfig.java @@ -39,12 +39,12 @@ public class NonAssessmentConfig implements AssessmentConfig { } @Override - public boolean isScoreEvaluationPersisted() { + public boolean isEvaluationPersisted() { return false; } @Override - public boolean isScoreEvaluationCalculated() { + public boolean isEvaluationCalculated() { return false; } diff --git a/src/main/java/org/olat/course/assessment/manager/CourseAssessmentServiceImpl.java b/src/main/java/org/olat/course/assessment/manager/CourseAssessmentServiceImpl.java index deb20f7ed64029731d970876f4a7f5c6d0dda140..bcac004fa20c06276a18f3ef857752d57cf95191 100644 --- a/src/main/java/org/olat/course/assessment/manager/CourseAssessmentServiceImpl.java +++ b/src/main/java/org/olat/course/assessment/manager/CourseAssessmentServiceImpl.java @@ -122,9 +122,9 @@ public class CourseAssessmentServiceImpl implements CourseAssessmentService { AssessmentHandler assessmentHandler = getAssessmentHandler(courseNode); AssessmentEvaluation assessmentEvaluation = AssessmentEvaluation.EMPTY_EVAL; - if (assessmentConfig.isScoreEvaluationCalculated()) { + if (assessmentConfig.isEvaluationCalculated()) { assessmentEvaluation = assessmentHandler.getCalculatedScoreEvaluation(courseNode, userCourseEnvironment); - } else if (assessmentConfig.isScoreEvaluationPersisted()) { + } else if (assessmentConfig.isEvaluationPersisted()) { assessmentEvaluation = getPersistedAssessmentEvaluation(courseNode, userCourseEnvironment); } // Other handlers should be able to have other implementations diff --git a/src/main/java/org/olat/course/assessment/ui/tool/IdentityListCourseNodeController.java b/src/main/java/org/olat/course/assessment/ui/tool/IdentityListCourseNodeController.java index ec03574b731ebd8e4379b9c387486fa7ddaea291..f3588769248fe6c0986cc2e5acd0588d77ed63e7 100644 --- a/src/main/java/org/olat/course/assessment/ui/tool/IdentityListCourseNodeController.java +++ b/src/main/java/org/olat/course/assessment/ui/tool/IdentityListCourseNodeController.java @@ -358,7 +358,7 @@ public class IdentityListCourseNodeController extends FormBasicController if(assessmentConfig.hasAttempts()) { columnsModel.addFlexiColumnModel(new DefaultFlexiColumnModel(IdentityCourseElementCols.attempts)); } - if(!assessmentConfig.isScoreEvaluationCalculated()) { + if(!assessmentConfig.isEvaluationCalculated()) { columnsModel.addFlexiColumnModel(new DefaultFlexiColumnModel(IdentityCourseElementCols.userVisibility, new UserVisibilityCellRenderer(getTranslator()))); } diff --git a/src/main/java/org/olat/course/nodes/basiclti/LTIAssessmentConfig.java b/src/main/java/org/olat/course/nodes/basiclti/LTIAssessmentConfig.java index 30c2a555edf165f212bde5180a211dae53c0297d..eb45acc4ee208c3b8cd7d36dea37db63c599d74c 100644 --- a/src/main/java/org/olat/course/nodes/basiclti/LTIAssessmentConfig.java +++ b/src/main/java/org/olat/course/nodes/basiclti/LTIAssessmentConfig.java @@ -45,12 +45,12 @@ public class LTIAssessmentConfig implements AssessmentConfig { } @Override - public boolean isScoreEvaluationPersisted() { + public boolean isEvaluationPersisted() { return true; } @Override - public boolean isScoreEvaluationCalculated() { + public boolean isEvaluationCalculated() { return false; } diff --git a/src/main/java/org/olat/course/nodes/iq/IQTESTAssessmentConfig.java b/src/main/java/org/olat/course/nodes/iq/IQTESTAssessmentConfig.java index 9d7fd0a40f896801cb5e4725ffa2b460fadcf084..816a15f0061bf3accdd5f576398710f4f3884020 100644 --- a/src/main/java/org/olat/course/nodes/iq/IQTESTAssessmentConfig.java +++ b/src/main/java/org/olat/course/nodes/iq/IQTESTAssessmentConfig.java @@ -47,12 +47,12 @@ public class IQTESTAssessmentConfig implements AssessmentConfig { } @Override - public boolean isScoreEvaluationPersisted() { + public boolean isEvaluationPersisted() { return true; } @Override - public boolean isScoreEvaluationCalculated() { + public boolean isEvaluationCalculated() { return false; } diff --git a/src/main/java/org/olat/course/nodes/scorm/ScormAssessmentConfig.java b/src/main/java/org/olat/course/nodes/scorm/ScormAssessmentConfig.java index 652c886081254c73378a25ab3a07c591bca1ce21..a261f355449445c28f522e096f8983c217311be7 100644 --- a/src/main/java/org/olat/course/nodes/scorm/ScormAssessmentConfig.java +++ b/src/main/java/org/olat/course/nodes/scorm/ScormAssessmentConfig.java @@ -42,12 +42,12 @@ public class ScormAssessmentConfig implements AssessmentConfig { } @Override - public boolean isScoreEvaluationPersisted() { + public boolean isEvaluationPersisted() { return true; } @Override - public boolean isScoreEvaluationCalculated() { + public boolean isEvaluationCalculated() { return false; } diff --git a/src/main/java/org/olat/course/nodes/st/STAssessmentConfig.java b/src/main/java/org/olat/course/nodes/st/STAssessmentConfig.java index c78df5cdec799c7d61f67cf6d680a66ef5820eac..6994eaa9429ad091491d91dae91211fa50360066 100644 --- a/src/main/java/org/olat/course/nodes/st/STAssessmentConfig.java +++ b/src/main/java/org/olat/course/nodes/st/STAssessmentConfig.java @@ -44,12 +44,12 @@ public class STAssessmentConfig implements AssessmentConfig { } @Override - public boolean isScoreEvaluationPersisted() { + public boolean isEvaluationPersisted() { return true; } @Override - public boolean isScoreEvaluationCalculated() { + public boolean isEvaluationCalculated() { return true; } diff --git a/src/main/java/org/olat/course/run/scoring/ScoreAccounting.java b/src/main/java/org/olat/course/run/scoring/ScoreAccounting.java index 1a6d481ee6512ebcb5be33ebbe8aeb16e11b414a..13032db95d8d71016b2df47d875fcc113d3bc740 100644 --- a/src/main/java/org/olat/course/run/scoring/ScoreAccounting.java +++ b/src/main/java/org/olat/course/run/scoring/ScoreAccounting.java @@ -153,14 +153,14 @@ public class ScoreAccounting { AssessmentEvaluation se = null; if (recursionLevel <= 15) { AssessmentConfig assessmentConfig = courseAssessmentService.getAssessmentConfig(cn); - if (update && assessmentConfig.isScoreEvaluationCalculated()) { + if (update && assessmentConfig.isEvaluationCalculated()) { AssessmentEntry entry = identToEntries.get(cn.getIdent()); se = calculateScoreEvaluation(entry, cn, assessmentConfig); cachedScoreEvals.put(cn, se); } else { se = cachedScoreEvals.get(cn); if (se == null) { // result of this node has not been cached yet, do it - if(assessmentConfig.isScoreEvaluationPersisted()) { + if(assessmentConfig.isEvaluationPersisted()) { AssessmentEntry entry = identToEntries.get(cn.getIdent()); se = courseAssessmentService.toAssessmentEvaluation(entry, assessmentConfig); } else {