From f3019e3c7f2fce1b6b51dac7de1df33ded5d7ee8 Mon Sep 17 00:00:00 2001
From: srosse <stephane.rosse@frentix.com>
Date: Fri, 1 May 2020 13:24:41 +0200
Subject: [PATCH] no-jira: add noopener to link lists and external link
component
---
src/main/java/de/bps/course/nodes/ll/_content/run.html | 2 +-
.../olat/core/gui/components/link/ExternalLinkRenderer.java | 3 +++
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/src/main/java/de/bps/course/nodes/ll/_content/run.html b/src/main/java/de/bps/course/nodes/ll/_content/run.html
index 790724ed476..c52741073a2 100644
--- a/src/main/java/de/bps/course/nodes/ll/_content/run.html
+++ b/src/main/java/de/bps/course/nodes/ll/_content/run.html
@@ -3,7 +3,7 @@
#foreach($link in $linkList)
<li class="o_block">
<h5>
- <a href="#if($link.intern) $mapperBaseUrl$link.getTarget() #else $link.getTarget() #end" target="$link.getHtmlTarget()" class="o_desc">
+ <a href="#if($link.intern) $mapperBaseUrl$link.getTarget() #else $link.getTarget() #end" target="$link.getHtmlTarget()" rel="noopener noreferrer" class="o_desc">
$r.escapeHtml($link.getDescription())
<small>
#if($link.intern) $mapperBaseUrl$link.getTarget() #else $link.getTarget() #end
diff --git a/src/main/java/org/olat/core/gui/components/link/ExternalLinkRenderer.java b/src/main/java/org/olat/core/gui/components/link/ExternalLinkRenderer.java
index df5aff02344..f6cdb1cf7ca 100644
--- a/src/main/java/org/olat/core/gui/components/link/ExternalLinkRenderer.java
+++ b/src/main/java/org/olat/core/gui/components/link/ExternalLinkRenderer.java
@@ -56,6 +56,9 @@ public class ExternalLinkRenderer extends DefaultComponentRenderer {
if(StringHelper.containsNonWhitespace(link.getTooltip())) {
sb.append(" title=\"").append(link.getTooltip()).append("\"");
}
+ if(StringHelper.containsNonWhitespace(link.getTooltip())) {
+ sb.append(" rel=\"noopener noreferrer\"");
+ }
sb.append(">");
if(StringHelper.containsNonWhitespace(link.getIconLeftCSS())) {
--
GitLab