diff --git a/src/main/java/org/olat/modules/gotomeeting/ui/EditOrganizerNameController.java b/src/main/java/org/olat/modules/gotomeeting/ui/EditOrganizerNameController.java index d9017165ac5cf08cc594565da3fa3f31de6d5710..e8d32a107530ee78a284dfc7cba262d64abb30f8 100644 --- a/src/main/java/org/olat/modules/gotomeeting/ui/EditOrganizerNameController.java +++ b/src/main/java/org/olat/modules/gotomeeting/ui/EditOrganizerNameController.java @@ -60,8 +60,8 @@ public class EditOrganizerNameController extends FormBasicController { FormLayoutContainer buttonLayout = FormLayoutContainer.createButtonLayout("buttons", getTranslator()); formLayout.add("buttons", buttonLayout); - uifactory.addFormSubmitButton("ok", buttonLayout); uifactory.addFormCancelButton("cancel", buttonLayout, ureq, getWindowControl()); + uifactory.addFormSubmitButton("ok", buttonLayout); } @Override diff --git a/src/main/java/org/olat/modules/gotomeeting/ui/EditTrainingController.java b/src/main/java/org/olat/modules/gotomeeting/ui/EditTrainingController.java index 17f564b8701f68e86970101a03e90453b3a37806..0977a00c676d56e09c843a2376c24a806009720e 100644 --- a/src/main/java/org/olat/modules/gotomeeting/ui/EditTrainingController.java +++ b/src/main/java/org/olat/modules/gotomeeting/ui/EditTrainingController.java @@ -153,7 +153,7 @@ public class EditTrainingController extends FormBasicController { @Override protected boolean validateFormLogic(UserRequest ureq) { - boolean allOk = true; + boolean allOk = super.validateFormLogic(ureq); if(meeting == null || meeting.getOrganizer() == null) { organizersEl.clearError(); @@ -201,7 +201,7 @@ public class EditTrainingController extends FormBasicController { } } - return allOk & super.validateFormLogic(ureq); + return allOk; } @Override diff --git a/src/main/java/org/olat/modules/gotomeeting/ui/GoToOrganizerListAdminController.java b/src/main/java/org/olat/modules/gotomeeting/ui/GoToOrganizerListAdminController.java index bbabbae38c79c89b0e95e1a6029832bca79912e7..60040f24609d77e391efeaa0eb8ddc8317febffa 100644 --- a/src/main/java/org/olat/modules/gotomeeting/ui/GoToOrganizerListAdminController.java +++ b/src/main/java/org/olat/modules/gotomeeting/ui/GoToOrganizerListAdminController.java @@ -155,7 +155,7 @@ public class GoToOrganizerListAdminController extends FormBasicController implem @Override protected void event(UserRequest ureq, Controller source, Event event) { - if(editOrganizerNameController == source || loginOrganizerController == null) { + if(editOrganizerNameController == source || loginOrganizerController == source) { if(event == Event.DONE_EVENT) { updateModel(); } @@ -176,9 +176,11 @@ public class GoToOrganizerListAdminController extends FormBasicController implem private void cleanUp() { removeAsListenerAndDispose(editOrganizerNameController); + removeAsListenerAndDispose(loginOrganizerController); removeAsListenerAndDispose(confirmRemoveOrganizer); removeAsListenerAndDispose(cmc); editOrganizerNameController = null; + loginOrganizerController = null; confirmRemoveOrganizer = null; cmc = null; } diff --git a/src/main/java/org/olat/modules/gotomeeting/ui/LoginOrganizerController.java b/src/main/java/org/olat/modules/gotomeeting/ui/LoginOrganizerController.java index 9609bb01b612cb52eedbba22b7d37da009eec41f..b06a8a3507f49e1c30e114df27522b515d6af0ba 100644 --- a/src/main/java/org/olat/modules/gotomeeting/ui/LoginOrganizerController.java +++ b/src/main/java/org/olat/modules/gotomeeting/ui/LoginOrganizerController.java @@ -89,8 +89,8 @@ public class LoginOrganizerController extends FormBasicController { FormLayoutContainer buttonLayout = FormLayoutContainer.createButtonLayout("buttons", getTranslator()); formLayout.add("buttons", buttonLayout); - uifactory.addFormSubmitButton("ok", buttonLayout); uifactory.addFormCancelButton("cancel", buttonLayout, ureq, getWindowControl()); + uifactory.addFormSubmitButton("ok", buttonLayout); } @Override @@ -100,7 +100,7 @@ public class LoginOrganizerController extends FormBasicController { @Override protected boolean validateFormLogic(UserRequest ureq) { - boolean allOk = true; + boolean allOk = super.validateFormLogic(ureq); usernameEl.clearError(); if(!StringHelper.containsNonWhitespace(usernameEl.getValue())) { @@ -114,7 +114,7 @@ public class LoginOrganizerController extends FormBasicController { allOk &= false; } - return allOk & super.validateFormLogic(ureq); + return allOk; } @Override