From af1ee7d5ccb7e3170e7c5465ec2d6663bd8c669f Mon Sep 17 00:00:00 2001
From: srosse <none@none>
Date: Wed, 26 Mar 2014 12:02:11 +0100
Subject: [PATCH] OO-1038: restraints character boundaries
---
src/main/java/org/olat/core/util/StringHelper.java | 2 +-
src/test/java/org/olat/core/util/StringHelperTest.java | 8 ++++++++
2 files changed, 9 insertions(+), 1 deletion(-)
diff --git a/src/main/java/org/olat/core/util/StringHelper.java b/src/main/java/org/olat/core/util/StringHelper.java
index e7d4e98501a..ee27b271683 100644
--- a/src/main/java/org/olat/core/util/StringHelper.java
+++ b/src/main/java/org/olat/core/util/StringHelper.java
@@ -404,7 +404,7 @@ public class StringHelper {
char[] charArr = string.toCharArray();
for(int i=charArr.length; i-->stop; ) {
char ch = charArr[i];
- if(ch < 47 || ch > 58) {
+ if(ch < 48 || ch > 57) {
return false;
}
}
diff --git a/src/test/java/org/olat/core/util/StringHelperTest.java b/src/test/java/org/olat/core/util/StringHelperTest.java
index df5b39c5676..14fa9044a17 100644
--- a/src/test/java/org/olat/core/util/StringHelperTest.java
+++ b/src/test/java/org/olat/core/util/StringHelperTest.java
@@ -112,12 +112,20 @@ public class StringHelperTest {
@Test
public void isLong() {
Assert.assertTrue(StringHelper.isLong("234"));
+ Assert.assertTrue(StringHelper.isLong("0123456789"));
Assert.assertTrue(StringHelper.isLong("9223372036854775807"));
Assert.assertTrue(StringHelper.isLong("-9223372036854775807"));
+ //check some unacceptable strings
Assert.assertFalse(StringHelper.isLong("10223372036854775807"));
Assert.assertFalse(StringHelper.isLong("-dru"));
Assert.assertFalse(StringHelper.isLong("OpenOLAT"));
Assert.assertFalse(StringHelper.isLong("A very long number with a lot of characters"));
+
+ //check ascii range
+ Assert.assertFalse(StringHelper.isLong("/"));
+ Assert.assertFalse(StringHelper.isLong(":"));
+ Assert.assertFalse(StringHelper.isLong("."));
+ Assert.assertFalse(StringHelper.isLong(";"));
}
}
--
GitLab