From aa294d093126a266b62aa36d69738975d0f6b60a Mon Sep 17 00:00:00 2001
From: srosse <stephane.rosse@frentix.com>
Date: Tue, 24 Mar 2020 09:09:43 +0100
Subject: [PATCH] OO-4593: only save the number of user in high score if option
 selected

---
 .../course/highscore/ui/HighScoreEditController.java     | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/src/main/java/org/olat/course/highscore/ui/HighScoreEditController.java b/src/main/java/org/olat/course/highscore/ui/HighScoreEditController.java
index 5c5c12e18fa..e66df664941 100644
--- a/src/main/java/org/olat/course/highscore/ui/HighScoreEditController.java
+++ b/src/main/java/org/olat/course/highscore/ui/HighScoreEditController.java
@@ -267,8 +267,13 @@ public class HighScoreEditController extends FormBasicController {
 		config.set(CONFIG_KEY_DATESTART, dateStart.getDate());
 		config.set(CONFIG_KEY_ANONYMIZE, displayAnonymous.isSelected(0));
 		if (showListing.isSelected(0)) {
-			config.set(CONFIG_KEY_BESTONLY, bestOnlyEl.getSelected());
-			config.set(CONFIG_KEY_NUMUSER, numTableRows.getIntValue());
+			int bestOnly = bestOnlyEl.getSelected();
+			config.set(CONFIG_KEY_BESTONLY, bestOnly);
+			if(bestOnly == 1) {
+				config.set(CONFIG_KEY_NUMUSER, numTableRows.getIntValue());
+			} else {
+				config.remove(CONFIG_KEY_NUMUSER);
+			}
 		}
 		fireEvent(ureq, Event.DONE_EVENT);
 	}
-- 
GitLab