diff --git a/src/main/java/de/bps/olat/portal/institution/InstitutionPortletRunController.java b/src/main/java/de/bps/olat/portal/institution/InstitutionPortletRunController.java index 6c2d196923b457bbaf43c2e641d1797f5a5105f6..36c8072c1b17839cd6cc0580c4ad24270670ac15 100644 --- a/src/main/java/de/bps/olat/portal/institution/InstitutionPortletRunController.java +++ b/src/main/java/de/bps/olat/portal/institution/InstitutionPortletRunController.java @@ -35,6 +35,7 @@ import org.olat.core.gui.control.WindowControl; import org.olat.core.gui.control.controller.BasicController; import org.olat.core.id.UserConstants; import org.olat.core.id.context.BusinessControlFactory; +import org.olat.core.logging.OLog; import org.olat.core.logging.Tracing; import org.olat.core.util.StringHelper; import org.olat.repository.RepositoryEntry; @@ -42,6 +43,8 @@ import org.olat.repository.RepositoryManager; public class InstitutionPortletRunController extends BasicController { + private static final OLog log = Tracing.createLoggerFor(InstitutionPortletRunController.class); + private VelocityContainer portletVC; private List<String> polyLinks; private Map<Link, PolymorphLink> mapLinks; @@ -153,13 +156,13 @@ public class InstitutionPortletRunController extends BasicController { try { resultIDForUser = Long.parseLong(resultIDForUserS); } catch (NumberFormatException e) { - Tracing.createLoggerFor(InstitutionPortletRunController.class).error(e.getMessage()); + log.error(e.getMessage()); } } try { defaultID = Long.parseLong(polyLink.getDefaultLink()); } catch (NumberFormatException e) { - Tracing.createLoggerFor(InstitutionPortletRunController.class).error(e.getMessage()); + log.error(e.getMessage()); } if (polyLink.getLinkType().equals(InstitutionPortlet.TYPE_COURSE)) { @@ -188,7 +191,7 @@ public class InstitutionPortletRunController extends BasicController { String businessPath = "[CatalogEntry:" + ceKey + "]"; NewControllerFactory.getInstance().launch(businessPath, ureq, getWindowControl()); } catch (Exception e) { - Tracing.createLoggerFor(InstitutionPortletRunController.class).error(e.getMessage()); + log.error(e.getMessage()); getWindowControl().setWarning(translate("warn.cantlaunch")); } } diff --git a/src/main/java/de/bps/webservices/WebServiceModule.java b/src/main/java/de/bps/webservices/WebServiceModule.java index bfd32012651e432652310d94589eae8dd4622913..d41483d9edf32b7479f00ca854af18e0bba0180c 100644 --- a/src/main/java/de/bps/webservices/WebServiceModule.java +++ b/src/main/java/de/bps/webservices/WebServiceModule.java @@ -81,7 +81,7 @@ public class WebServiceModule implements Initializable { String address = services.get(serviceName).get(1); mapIdToInstName.put(id, instName); mapInstNameToAddress.put(instName, address); - Tracing.createLoggerFor(getClass()).audit(serviceName + " # " + id + " # " + instName + " # " + address); + log.audit(serviceName + " # " + id + " # " + instName + " # " + address); Service service = new Service(serviceName, mapIdToInstName, mapInstNameToAddress); configuration.put(service.getName(), service); } diff --git a/src/main/java/de/bps/webservices/clients/onyxreporter/OnyxReporterConnector.java b/src/main/java/de/bps/webservices/clients/onyxreporter/OnyxReporterConnector.java index 84d4456f925a5843e05e02552b8e900cec829787..64ff6669cdc2678dac31c155b3d0ccf968fb50c3 100644 --- a/src/main/java/de/bps/webservices/clients/onyxreporter/OnyxReporterConnector.java +++ b/src/main/java/de/bps/webservices/clients/onyxreporter/OnyxReporterConnector.java @@ -600,7 +600,7 @@ public class OnyxReporterConnector { } } } catch (Exception e) { - Tracing.createLoggerFor(getClass()).error("Error while trying to connect to webservice: " + target, e); + log.error("Error while trying to connect to webservice: " + target, e); } return false; } diff --git a/src/main/java/org/olat/commons/servlets/RSSServlet.java b/src/main/java/org/olat/commons/servlets/RSSServlet.java index 5b874f0efac567c38893014fe10a55e67bc8dc1c..a402786bed0d12dc1862a28b5e52be25a342322b 100644 --- a/src/main/java/org/olat/commons/servlets/RSSServlet.java +++ b/src/main/java/org/olat/commons/servlets/RSSServlet.java @@ -28,8 +28,6 @@ package org.olat.commons.servlets; import java.io.Writer; import java.util.Date; -import javax.servlet.ServletConfig; -import javax.servlet.ServletException; import javax.servlet.http.HttpServlet; import javax.servlet.http.HttpServletRequest; import javax.servlet.http.HttpServletResponse; @@ -63,32 +61,12 @@ public class RSSServlet extends HttpServlet { private static final long serialVersionUID = -674630331334472714L; private static final OLog log = Tracing.createLoggerFor(RSSServlet.class); public static final String DEFAULT_ENCODING = "UTF-8"; - private static int outputBufferSize = 2048; - private static int inputBufferSize = 2048; - - - /** - * @see javax.servlet.Servlet#init(javax.servlet.ServletConfig) - */ - public void init(ServletConfig servletConfig) throws ServletException { - super.init(servletConfig); - log.info("init statics servlet"); - try { - String bufSize = servletConfig.getInitParameter("input"); - inputBufferSize = Integer.parseInt(bufSize); - bufSize = servletConfig.getInitParameter("output"); - outputBufferSize = Integer.parseInt(bufSize); - } catch (Exception e) { - log.warn("problem with config parameters for rss servlets:", e); - } - log.info("input buffer size: " + inputBufferSize); - log.info("output buffer size: " + outputBufferSize); - } /** * @see javax.servlet.http.HttpServlet#service(javax.servlet.http.HttpServletRequest, * javax.servlet.http.HttpServletResponse) */ + @Override protected void service(HttpServletRequest req, HttpServletResponse resp) { Tracing.setUreq(req); I18nManager.attachI18nInfoToThread(req); @@ -138,7 +116,7 @@ public class RSSServlet extends HttpServlet { // on the client-side which remains unnoticed (network partitioning) DBFactory.getInstance().intermediateCommit(); - response.setBufferSize(outputBufferSize); + response.setBufferSize(response.getBufferSize()); String encoding = feed.getEncoding(); if (encoding == null) { diff --git a/src/main/java/org/olat/core/gui/media/ServletUtil.java b/src/main/java/org/olat/core/gui/media/ServletUtil.java index 68fbf52b6848a3837de013274e57139827b2cc24..45fd4d6d695007d93bd76c51f221456fe0cf3689 100644 --- a/src/main/java/org/olat/core/gui/media/ServletUtil.java +++ b/src/main/java/org/olat/core/gui/media/ServletUtil.java @@ -201,9 +201,10 @@ public class ServletUtil { if (size != null) { httpResp.setContentLength(size.intValue()); } + int bufferSize = httpResp.getBufferSize(); // buffer input stream - bis = new BufferedInputStream(in); - IOUtils.copy(bis, out); + bis = new BufferedInputStream(in, bufferSize); + IOUtils.copyLarge(bis, out, new byte[bufferSize]); } if (debug) { diff --git a/src/main/java/org/olat/course/nodes/ProjectBrokerCourseNode.java b/src/main/java/org/olat/course/nodes/ProjectBrokerCourseNode.java index 62edaaebc93591d1600913de7e55466f370d71f7..1c93e6cd3e2c90793a1292011593bfe6d62e8e88 100644 --- a/src/main/java/org/olat/course/nodes/ProjectBrokerCourseNode.java +++ b/src/main/java/org/olat/course/nodes/ProjectBrokerCourseNode.java @@ -224,7 +224,7 @@ public class ProjectBrokerCourseNode extends GenericCourseNode implements Assess wControl = bcf.createBusinessWindowControl(businessControl, wControl); } catch (NumberFormatException e) { // ups, nodecmd is not a message, what the heck is it then? - Tracing.createLoggerFor(this.getClass()).warn("Could not create message ID from given nodemcd::" + nodecmd, e); + log.warn("Could not create message ID from given nodemcd::" + nodecmd, e); } } controller = ProjectBrokerControllerFactory.createRunController(ureq, wControl,userCourseEnv, this); diff --git a/src/main/java/org/olat/modules/wiki/Wiki.java b/src/main/java/org/olat/modules/wiki/Wiki.java index 1b07893747f098f87512cfd900119c7b70d24885..10b632b2730da7b8c0d7f2494a15efa7b893632a 100644 --- a/src/main/java/org/olat/modules/wiki/Wiki.java +++ b/src/main/java/org/olat/modules/wiki/Wiki.java @@ -229,7 +229,6 @@ public class Wiki implements WikiContainer, Serializable { } String pageName = p.getProperty(WikiManager.PAGENAME); if(pageName == null){ - OLog log = Tracing.createLoggerFor(Wiki.class); log.warn("wiki properties page is persent but without content. Name:"+leaf.getName()); return null; } diff --git a/src/main/webapp-tomcat/WEB-INF/web.xml b/src/main/webapp-tomcat/WEB-INF/web.xml index 3c2e1eded83b6f7e4b00eb59405f28854367d9dc..32c49a684699b422d5250135b10809e301b7bfa0 100644 --- a/src/main/webapp-tomcat/WEB-INF/web.xml +++ b/src/main/webapp-tomcat/WEB-INF/web.xml @@ -195,17 +195,6 @@ <servlet> <servlet-name>rss</servlet-name> <servlet-class>org.olat.commons.servlets.RSSServlet</servlet-class> - - <init-param> - <param-name>input</param-name> - <param-value>32768</param-value> - </init-param> - - <init-param> - <param-name>output</param-name> - <param-value>32768</param-value> - </init-param> - <load-on-startup>3</load-on-startup> </servlet> diff --git a/src/main/webapp-wildfly/WEB-INF/web.xml b/src/main/webapp-wildfly/WEB-INF/web.xml index ce84ffcce0eaa82d947abdd0f84a2c51f6729083..70058c0b36d4ea9a8787bd31bb3b56914e08d163 100644 --- a/src/main/webapp-wildfly/WEB-INF/web.xml +++ b/src/main/webapp-wildfly/WEB-INF/web.xml @@ -142,17 +142,6 @@ <servlet> <servlet-name>rss</servlet-name> <servlet-class>org.olat.commons.servlets.RSSServlet</servlet-class> - - <init-param> - <param-name>input</param-name> - <param-value>32768</param-value> - </init-param> - - <init-param> - <param-name>output</param-name> - <param-value>32768</param-value> - </init-param> - <load-on-startup>3</load-on-startup> </servlet>