From 94103761778c273e69774b6618541796468021a9 Mon Sep 17 00:00:00 2001
From: srosse <stephane.rosse@frentix.com>
Date: Thu, 20 Jun 2019 13:45:31 +0200
Subject: [PATCH] no-jira: enhance more selenium tests for Firefox

---
 .../java/org/olat/selenium/page/qpool/QuestionPoolPage.java   | 4 ++--
 .../olat/selenium/page/repository/RepositoryAccessPage.java   | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/test/java/org/olat/selenium/page/qpool/QuestionPoolPage.java b/src/test/java/org/olat/selenium/page/qpool/QuestionPoolPage.java
index 4dae8506e9e..a7645022549 100644
--- a/src/test/java/org/olat/selenium/page/qpool/QuestionPoolPage.java
+++ b/src/test/java/org/olat/selenium/page/qpool/QuestionPoolPage.java
@@ -20,7 +20,6 @@
 package org.olat.selenium.page.qpool;
 
 import org.olat.ims.qti21.model.QTI21QuestionType;
-import org.olat.selenium.page.NavigationPage;
 import org.olat.selenium.page.graphene.OOGraphene;
 import org.openqa.selenium.By;
 import org.openqa.selenium.WebDriver;
@@ -127,6 +126,7 @@ public class QuestionPoolPage {
 		
 		By assessmentItemBy = By.cssSelector("ul.o_sel_assessment_item_config");
 		OOGraphene.waitElement(assessmentItemBy, browser);
+		OOGraphene.scrollTop(browser);
 		return this;
 	}
 	
@@ -174,7 +174,7 @@ public class QuestionPoolPage {
 	}
 	
 	public QuestionPoolPage clickToolbarBack() {
-		browser.findElement(NavigationPage.toolbarBackBy).click();
+		OOGraphene.clickBreadcrumbBack(browser);
 		OOGraphene.waitBusy(browser);
 		
 		By tableBy = By.cssSelector("div.o_table_flexi.o_rendertype_classic");
diff --git a/src/test/java/org/olat/selenium/page/repository/RepositoryAccessPage.java b/src/test/java/org/olat/selenium/page/repository/RepositoryAccessPage.java
index c8cc44d13ed..f6512823162 100644
--- a/src/test/java/org/olat/selenium/page/repository/RepositoryAccessPage.java
+++ b/src/test/java/org/olat/selenium/page/repository/RepositoryAccessPage.java
@@ -45,7 +45,7 @@ public class RepositoryAccessPage {
 			browser.findElement(allUsersBy).click();
 			OOGraphene.waitBusy(browser);
 			
-			By guestsBy = By.xpath("//div[contains(@class,'o_sel_repositoryentry_access_guest')]//label[input[@name='entry.access.guest' and @value='on']]");
+			By guestsBy = By.xpath("//div[contains(@class,'o_sel_repositoryentry_access_guest')]//label/input[@name='entry.access.guest' and @value='on']");
 			OOGraphene.waitElement(guestsBy, browser);
 			
 			if(access == UserAccess.guest) {
-- 
GitLab