diff --git a/src/main/java/org/olat/core/gui/control/generic/wizard/StepsMainRunController.java b/src/main/java/org/olat/core/gui/control/generic/wizard/StepsMainRunController.java index ad159fe9d9890248534786dc884d39bd1891f6c6..cd78a0c8784ed8dd3743617f02634dc0c242c4fb 100644 --- a/src/main/java/org/olat/core/gui/control/generic/wizard/StepsMainRunController.java +++ b/src/main/java/org/olat/core/gui/control/generic/wizard/StepsMainRunController.java @@ -176,7 +176,7 @@ public class StepsMainRunController extends FormBasicController implements Gener */ @Override protected void doDispose() { - // + getWindowControl().getWindowBackOffice().removeCycleListener(this); } /* diff --git a/src/main/java/org/olat/core/gui/control/winmgr/WindowBackOfficeImpl.java b/src/main/java/org/olat/core/gui/control/winmgr/WindowBackOfficeImpl.java index 6a3a79b0eab77074bf0817fb5731243c8e1d3ead..c5f36a25512a7c3d21669b31ba08909671115523 100644 --- a/src/main/java/org/olat/core/gui/control/winmgr/WindowBackOfficeImpl.java +++ b/src/main/java/org/olat/core/gui/control/winmgr/WindowBackOfficeImpl.java @@ -91,9 +91,9 @@ public class WindowBackOfficeImpl implements WindowBackOffice { private GuiDebugDispatcherController guidebugC; private InlineTranslationInterceptHandlerController inlineTranslationC; - private List<ZIndexWrapper> guiMessages = new ArrayList<ZIndexWrapper>(); // request-transient render-related data + private List<ZIndexWrapper> guiMessages = new ArrayList<>(); // request-transient render-related data - private transient List<GenericEventListener> cycleListeners = new CopyOnWriteArrayList<GenericEventListener>(); + private transient List<GenericEventListener> cycleListeners = new CopyOnWriteArrayList<>(); WindowBackOfficeImpl(final WindowManagerImpl winmgrImpl, String windowName, ChiefController windowOwner, WindowSettings settings) { this.winmgrImpl = winmgrImpl; @@ -177,6 +177,7 @@ public class WindowBackOfficeImpl implements WindowBackOffice { /** * @see org.olat.core.gui.control.WindowBackOffice#sendCommandTo(org.olat.core.gui.control.winmgr.Command) */ + @Override public void sendCommandTo(Command wco) { if (ajaxC != null) ajaxC.sendCommandTo(new WindowCommand(this,wco)); } @@ -237,6 +238,7 @@ public class WindowBackOfficeImpl implements WindowBackOffice { * @param windowControl * @return */ + @Override public Controller createInlineTranslationDispatcherController(UserRequest ureq, WindowControl windowControl) { if (inlineTranslationC != null) throw new AssertException("Can't set the inline translation dispatcher twice!", null); inlineTranslationC = I18nUIFactory.createInlineTranslationIntercepHandlerController(ureq, windowControl); @@ -244,6 +246,7 @@ public class WindowBackOfficeImpl implements WindowBackOffice { return inlineTranslationC; } + @Override public Controller createAJAXController(UserRequest ureq) { boolean ajaxEnabled = winmgrImpl.isAjaxEnabled(); ajaxC = new AjaxController(ureq, this, ajaxEnabled); @@ -253,6 +256,7 @@ public class WindowBackOfficeImpl implements WindowBackOffice { /* (non-Javadoc) * @see org.olat.core.gui.control.WindowBackOffice#isDebuging() */ + @Override public boolean isDebuging() { return Settings.isDebuging(); } @@ -313,7 +317,6 @@ public class WindowBackOfficeImpl implements WindowBackOffice { // clear the added data for this cycle guiMessages.clear(); } - } @Override diff --git a/src/main/java/org/olat/ims/qti/container/qtielements/Response_label.java b/src/main/java/org/olat/ims/qti/container/qtielements/Response_label.java index c46b574182f3ca3612863b35f014791e61ada9b2..293ed2ef3170fd42131e964ca9099140df34880d 100644 --- a/src/main/java/org/olat/ims/qti/container/qtielements/Response_label.java +++ b/src/main/java/org/olat/ims/qti/container/qtielements/Response_label.java @@ -118,7 +118,7 @@ public class Response_label extends GenericQTIElement { appendParameterIdent(buffer, ri); buffer.append("\" type=\"text\" size=\"").append(columns).append("\" maxlength=\"").append(maxlength); if (iinput != null && !iinput.isEmpty() && iinput.getSingle(responseIdent) != null) { - buffer.append("\" value=\"").append(iinput.getSingle(getQTIIdent())); //TODO: LD: must this value be escapeHtml? + buffer.append("\" value=\"").append(StringHelper.escapeHtml(iinput.getSingle(getQTIIdent()))); } buffer.append("\" onchange=\"return setFormDirty('ofo_iq_item')\" onclick=\"return setFormDirty('ofo_iq_item')\" /><span> </span>"); } diff --git a/src/main/java/org/olat/instantMessaging/ui/InstantMessagingMainController.java b/src/main/java/org/olat/instantMessaging/ui/InstantMessagingMainController.java index a4e5e0f8617916f4f7f7751a0dcd7f287c1776a5..c25913d7b009addb780f007c9afabb66d2c3bc41 100644 --- a/src/main/java/org/olat/instantMessaging/ui/InstantMessagingMainController.java +++ b/src/main/java/org/olat/instantMessaging/ui/InstantMessagingMainController.java @@ -169,6 +169,7 @@ public class InstantMessagingMainController extends BasicController implements G imService.unlistenChat(getIdentity(), getPrivatListenToResourceable(), this); singleUserEventCenter.deregisterFor(this, InstantMessagingService.ASSESSMENT_EVENT_ORES); singleUserEventCenter.deregisterFor(this, InstantMessagingService.TOWER_EVENT_ORES); + getWindowControl().getWindowBackOffice().removeCycleListener(this); } public OLATResourceable getPrivatListenToResourceable() { diff --git a/src/main/java/org/olat/repository/handlers/WikiHandler.java b/src/main/java/org/olat/repository/handlers/WikiHandler.java index 6576cd39b33104c801bb6db086a3758c13b2423c..b847b1606b5b649cffd2405c439150850a32fe7d 100644 --- a/src/main/java/org/olat/repository/handlers/WikiHandler.java +++ b/src/main/java/org/olat/repository/handlers/WikiHandler.java @@ -214,7 +214,7 @@ public class WikiHandler implements RepositoryHandler { } else { controller = new WikiMainController(uureq, wwControl, entry.getOlatResource(), callback, null); } - return new OLATResourceableListeningWrapperController(ureq, wControl, entry.getOlatResource(), controller, null, ureq.getIdentity()); + return new OLATResourceableListeningWrapperController(uureq, wwControl, entry.getOlatResource(), controller, null, uureq.getIdentity()); } });