From 83762f6ec014b56ba0d0581cbef2c0eebbf1be87 Mon Sep 17 00:00:00 2001
From: uhensler <urs.hensler@frentix.com>
Date: Tue, 22 Oct 2019 14:55:36 +0200
Subject: [PATCH] OO-4207: Avoid unnecessary assessment evaluation
---
.../manager/LearningPathCourseTreeModelBuilder.java | 1 -
.../learningpath/ui/IdentityOverviewController.java | 11 +++++++----
2 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/src/main/java/org/olat/course/learningpath/manager/LearningPathCourseTreeModelBuilder.java b/src/main/java/org/olat/course/learningpath/manager/LearningPathCourseTreeModelBuilder.java
index 311357bd090..ac6becd1043 100644
--- a/src/main/java/org/olat/course/learningpath/manager/LearningPathCourseTreeModelBuilder.java
+++ b/src/main/java/org/olat/course/learningpath/manager/LearningPathCourseTreeModelBuilder.java
@@ -41,7 +41,6 @@ public class LearningPathCourseTreeModelBuilder extends CourseTreeModelBuilder {
public LearningPathCourseTreeModelBuilder(UserCourseEnvironment userCourseEnv) {
super(userCourseEnv);
- userCourseEnv.getScoreAccounting().evaluateAll(true);
}
@Override
diff --git a/src/main/java/org/olat/course/learningpath/ui/IdentityOverviewController.java b/src/main/java/org/olat/course/learningpath/ui/IdentityOverviewController.java
index 97aa086ab98..9ec199f492a 100644
--- a/src/main/java/org/olat/course/learningpath/ui/IdentityOverviewController.java
+++ b/src/main/java/org/olat/course/learningpath/ui/IdentityOverviewController.java
@@ -53,20 +53,22 @@ public class IdentityOverviewController extends BasicController implements Toole
private LearningPathListController learningPathListController;
- private RepositoryEntry courseEntry;
+ private final UserCourseEnvironment userCourseEnv;
+ private final RepositoryEntry courseEntry;
@Autowired
private AssessmentService assessmentService;
public IdentityOverviewController(UserRequest ureq, WindowControl wControl, TooledStackedPanel stackPanel,
- UserCourseEnvironment userCourseEnvironment) {
+ UserCourseEnvironment userCourseEnv) {
super(ureq, wControl);
this.stackPanel = stackPanel;
- this.courseEntry = userCourseEnvironment.getCourseEnvironment().getCourseGroupManager().getCourseEntry();
+ this.userCourseEnv = userCourseEnv;
+ this.courseEntry = userCourseEnv.getCourseEnvironment().getCourseGroupManager().getCourseEntry();
mainVC = createVelocityContainer("identity_overview");
- learningPathListController = new LearningPathListController(ureq, wControl, userCourseEnvironment);
+ learningPathListController = new LearningPathListController(ureq, wControl, userCourseEnv);
listenTo(learningPathListController);
mainVC.put("list", learningPathListController.getInitialComponent());
@@ -96,6 +98,7 @@ public class IdentityOverviewController extends BasicController implements Toole
assessmentEntry.setAssessmentStatus(null);
assessmentService.updateAssessmentEntry(assessmentEntry);
}
+ userCourseEnv.getScoreAccounting().evaluateAll(true);
learningPathListController.loadModel();
}
--
GitLab