From 6b481f2b68a4966cc55657ece1a968c5072b8390 Mon Sep 17 00:00:00 2001
From: srosse <none@none>
Date: Mon, 24 Apr 2017 12:38:15 +0200
Subject: [PATCH] OO-2714: fix rs if the assessed user is an evaluator too, fix
some missing translations
---
.../modules/forms/ui/CompareEvaluationsFormController.java | 4 ++++
.../org/olat/modules/forms/ui/EvaluationFormController.java | 2 +-
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/src/main/java/org/olat/modules/forms/ui/CompareEvaluationsFormController.java b/src/main/java/org/olat/modules/forms/ui/CompareEvaluationsFormController.java
index 62b14750078..5bb435e5c2c 100644
--- a/src/main/java/org/olat/modules/forms/ui/CompareEvaluationsFormController.java
+++ b/src/main/java/org/olat/modules/forms/ui/CompareEvaluationsFormController.java
@@ -183,6 +183,10 @@ public class CompareEvaluationsFormController extends FormBasicController {
private List<EvaluationFormElementWrapper> forgeTextInput(TextInput element) {
List<EvaluationFormResponse> responses = identifierToResponses.get(element.getId());
+ if (responses == null) {
+ // in review - selbstreview ??
+ return new ArrayList<EvaluationFormElementWrapper>();
+ }
List<EvaluationFormElementWrapper> inputWrappers = new ArrayList<>(responses.size());
for(EvaluationFormResponse response:responses) {
if(StringHelper.containsNonWhitespace(response.getStringuifiedResponse())) {
diff --git a/src/main/java/org/olat/modules/forms/ui/EvaluationFormController.java b/src/main/java/org/olat/modules/forms/ui/EvaluationFormController.java
index 084413b8983..03afb808e19 100644
--- a/src/main/java/org/olat/modules/forms/ui/EvaluationFormController.java
+++ b/src/main/java/org/olat/modules/forms/ui/EvaluationFormController.java
@@ -238,7 +238,7 @@ public class EvaluationFormController extends FormBasicController implements Val
if(element.getRows() > 0) {
rows = element.getRows();
}
- TextElement textEl = uifactory.addTextAreaElement("textinput_" + (count++), rows, 72, initialValue, flc);
+ TextElement textEl = uifactory.addTextAreaElement("textinput_" + (count++), null, Integer.MAX_VALUE, rows, 72, false, initialValue, flc);
textEl.setEnabled(!readOnly);
FormLink saveButton = uifactory.addFormLink("save_" + (count++), "save", null, flc, Link.BUTTON);
saveButton.setVisible(!readOnly);
--
GitLab