From 3e84cef673a3a2a31a25a61a4f46fa2f82f3bda6 Mon Sep 17 00:00:00 2001
From: srosse <none@none>
Date: Thu, 4 Jun 2015 13:16:25 +0200
Subject: [PATCH] no-jira: don't show invisible item in dropdown menu, only add
spacer if there is an item after it
---
.../gui/components/dropdown/DropdownRenderer.java | 11 +++++++++--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/src/main/java/org/olat/core/gui/components/dropdown/DropdownRenderer.java b/src/main/java/org/olat/core/gui/components/dropdown/DropdownRenderer.java
index f088fd90b2a..b4b9d6c0937 100644
--- a/src/main/java/org/olat/core/gui/components/dropdown/DropdownRenderer.java
+++ b/src/main/java/org/olat/core/gui/components/dropdown/DropdownRenderer.java
@@ -80,10 +80,17 @@ public class DropdownRenderer extends DefaultComponentRenderer {
sb.append(" ").append(dropdown.getElementCssClass());
}
sb.append("' role='menu'>");
+
+ boolean wantSpacer = false;
for(Component component:components) {
if(component instanceof Spacer) {
- sb.append("<li class='divider'></li>");
- } else {
+ wantSpacer = true;
+ } else if(component.isVisible()) {
+ if(wantSpacer) {
+ sb.append("<li class='divider'></li>");
+ wantSpacer = false;
+ }
+
if(component.isEnabled()) {
sb.append("<li>");
} else {
--
GitLab