From 3cefa2f12d5a41691dba2593ac3e713d9f9b007d Mon Sep 17 00:00:00 2001
From: srosse <none@none>
Date: Tue, 10 Mar 2015 08:50:01 +0100
Subject: [PATCH] OO-1468: only log error if the property to set is unknown (
or disabled )
---
src/main/java/org/olat/user/UserImpl.java | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/src/main/java/org/olat/user/UserImpl.java b/src/main/java/org/olat/user/UserImpl.java
index 4cfbfb09c5d..4b11e710465 100644
--- a/src/main/java/org/olat/user/UserImpl.java
+++ b/src/main/java/org/olat/user/UserImpl.java
@@ -33,6 +33,8 @@ import org.olat.core.commons.persistence.PersistentObject;
import org.olat.core.id.Preferences;
import org.olat.core.id.User;
import org.olat.core.id.UserConstants;
+import org.olat.core.logging.OLog;
+import org.olat.core.logging.Tracing;
import org.olat.user.propertyhandlers.UserPropertyHandler;
/**
@@ -55,6 +57,7 @@ import org.olat.user.propertyhandlers.UserPropertyHandler;
public class UserImpl extends PersistentObject implements User {
private static final long serialVersionUID = -2872102058369727753L;
+ private static final OLog log = Tracing.createLoggerFor(UserImpl.class);
private Preferences preferences;
@@ -158,6 +161,7 @@ public class UserImpl extends PersistentObject implements User {
/**
* @see org.olat.core.id.User#getProperty(java.lang.String, java.util.Locale)
*/
+ @Override
public String getProperty(String propertyName, Locale locale) {
UserManager um = UserManager.getInstance();
UserPropertyHandler propertyHandler = um.getUserPropertiesConfig().getPropertyHandler(propertyName);
@@ -169,10 +173,15 @@ public class UserImpl extends PersistentObject implements User {
/**
* @see org.olat.core.id.User#setProperty(java.lang.String, java.lang.String)
*/
+ @Override
public void setProperty(String propertyName, String propertyValue) {
UserManager um = UserManager.getInstance();
UserPropertyHandler propertyHandler = um.getUserPropertiesConfig().getPropertyHandler(propertyName);
- propertyHandler.setUserProperty(this, propertyValue);
+ if(propertyHandler == null) {
+ log.error("Try to set unkown property: " + propertyName + " for user: " + getKey());
+ } else {
+ propertyHandler.setUserProperty(this, propertyValue);
+ }
}
/**
--
GitLab