From 2ebab4169219f4d8da9794afcb862d53ae0de8a6 Mon Sep 17 00:00:00 2001
From: srosse <none@none>
Date: Thu, 6 Apr 2017 08:38:59 +0200
Subject: [PATCH] OO-2673: show a warning if no element is selected for
 deletion

---
 .../qti21/ui/editor/AssessmentTestComposerController.java    | 5 +++++
 .../ims/qti21/ui/editor/_i18n/LocalStrings_de.properties     | 1 +
 .../ims/qti21/ui/editor/_i18n/LocalStrings_en.properties     | 1 +
 3 files changed, 7 insertions(+)

diff --git a/src/main/java/org/olat/ims/qti21/ui/editor/AssessmentTestComposerController.java b/src/main/java/org/olat/ims/qti21/ui/editor/AssessmentTestComposerController.java
index ed8c770b1bf..1e29a138d0a 100644
--- a/src/main/java/org/olat/ims/qti21/ui/editor/AssessmentTestComposerController.java
+++ b/src/main/java/org/olat/ims/qti21/ui/editor/AssessmentTestComposerController.java
@@ -1195,6 +1195,11 @@ public class AssessmentTestComposerController extends MainLayoutBasicController
 		if(confirmDeleteCtrl != null) return;
 		
 		TreeNode selectedNode = menuTree.getSelectedNode();
+		if(selectedNode == null) {
+			showWarning("warning.atleastone");
+			return;
+		}
+		
 		Object uobject = selectedNode.getUserObject();
 		if(uobject instanceof AssessmentTest) {
 			showWarning("error.cannot.delete");
diff --git a/src/main/java/org/olat/ims/qti21/ui/editor/_i18n/LocalStrings_de.properties b/src/main/java/org/olat/ims/qti21/ui/editor/_i18n/LocalStrings_de.properties
index b5f51d373fb..54843f3ff5e 100644
--- a/src/main/java/org/olat/ims/qti21/ui/editor/_i18n/LocalStrings_de.properties
+++ b/src/main/java/org/olat/ims/qti21/ui/editor/_i18n/LocalStrings_de.properties
@@ -153,6 +153,7 @@ tools.reload.from.files=Dateien neu laden und im Puffer ersetzen
 tools.reload.from.files.tooltip=Only visible to administrators.
 warning.alien.assessment.item=Dieser Fragetyp kann nicht mit dem OpenOLAT-Editor bearbeitet werden.
 warning.alien.assessment.test=Dieser Test kann nicht mit dem OpenOLAT-Editor bearbeitet werden.
+warning.atleastone=Bitte w\u00E4hlen Sie mindestens ein Element.
 warning.atleastonesection=Diese Sektion kann nicht gel\u00F6scht werden. Ein Test oder ein Test-Part muss mindestens eine Sektion enthalten.
 warning.feedback.cutvalue=Feedback wird aktiviert sobald bei "Notwendige Punktzahl f\u00FCr 'Bestanden'" eine Punktzahl eingegeben wurde.
 warning.in.use=Die Ressource wird bereits f\u00FCr Auswertung verwendet. Die Bearbeitung ist begrenzt.
diff --git a/src/main/java/org/olat/ims/qti21/ui/editor/_i18n/LocalStrings_en.properties b/src/main/java/org/olat/ims/qti21/ui/editor/_i18n/LocalStrings_en.properties
index 8fd4a92c65b..f803608733c 100644
--- a/src/main/java/org/olat/ims/qti21/ui/editor/_i18n/LocalStrings_en.properties
+++ b/src/main/java/org/olat/ims/qti21/ui/editor/_i18n/LocalStrings_en.properties
@@ -153,6 +153,7 @@ tools.reload.from.files=Reload files and refresh cache
 tools.reload.from.files.tooltip=Only visible to administrators.
 warning.alien.assessment.item=This question type cannot be processed with the OpenOLAT editor.
 warning.alien.assessment.test=This test cannot be processed with the OpenOLAT editor.
+warning.atleastone=Please, choose at least one element.
 warning.atleastonesection=The section cannot be deleted. A test or a test part must contain at least one section.
 warning.feedback.cutvalue=The feedback is based on the cut value. You need to define it first.
 warning.in.use=The resource is already used for assessment purpose. Editing is limited.
-- 
GitLab