From 0c067b2ebde74ee90f92e6e9e257e6ace82c33d9 Mon Sep 17 00:00:00 2001 From: srosse <none@none> Date: Thu, 18 Jan 2018 08:34:13 +0100 Subject: [PATCH] OO-3243: prevent index out of bounds if url is empty --- src/main/java/org/olat/core/gui/components/Window.java | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/main/java/org/olat/core/gui/components/Window.java b/src/main/java/org/olat/core/gui/components/Window.java index fe1d8dcd1a7..af876691854 100644 --- a/src/main/java/org/olat/core/gui/components/Window.java +++ b/src/main/java/org/olat/core/gui/components/Window.java @@ -902,7 +902,10 @@ public class Window extends AbstractComponent implements CustomCSSDelegate { sb.append("try { o_info.businessPath='").append(url).append("';"); // Add analytics code if (analyticsSPI != null) { - analyticsSPI.analyticsCountPageJavaScript(sb, this.getTitle(), url.substring(Settings.getServerContextPathURI().length())); + String serverUri = Settings.getServerContextPathURI(); + if(url != null && url.startsWith(serverUri)) { + analyticsSPI.analyticsCountPageJavaScript(sb, getTitle(), url.substring(serverUri.length())); + } } sb.append(" } catch(e) { }"); -- GitLab