From 015774c1b9f2d52d4b87279334eaf9474a968bb3 Mon Sep 17 00:00:00 2001
From: srosse <none@none>
Date: Tue, 29 May 2018 17:02:53 +0200
Subject: [PATCH] no-jira: try to harden Unit Test for certificates REST API
---
src/test/java/org/olat/restapi/CertificationTest.java | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/src/test/java/org/olat/restapi/CertificationTest.java b/src/test/java/org/olat/restapi/CertificationTest.java
index ec08a751e32..129334c1fdf 100644
--- a/src/test/java/org/olat/restapi/CertificationTest.java
+++ b/src/test/java/org/olat/restapi/CertificationTest.java
@@ -78,6 +78,7 @@ public class CertificationTest extends OlatJerseyTestCase {
Identity assessedIdentity = JunitTestHelper.createAndPersistIdentityAsRndUser("cert-1");
Identity author = JunitTestHelper.createAndPersistIdentityAsAuthor("cert-2");
RepositoryEntry entry = JunitTestHelper.deployBasicCourse(author);
+ dbInstance.commitAndCloseSession();
CertificateInfos certificateInfos = new CertificateInfos(assessedIdentity, 2.0f, true);
Certificate certificate = certificatesManager.generateCertificate(certificateInfos, entry, null, false);
@@ -114,6 +115,7 @@ public class CertificationTest extends OlatJerseyTestCase {
Identity unassessedIdentity = JunitTestHelper.createAndPersistIdentityAsRndUser("cert-12");
Identity author = JunitTestHelper.createAndPersistIdentityAsAuthor("cert-2");
RepositoryEntry entry = JunitTestHelper.deployBasicCourse(author);
+ dbInstance.commitAndCloseSession();
CertificateInfos certificateInfos = new CertificateInfos(assessedIdentity, 2.0f, true);
Certificate certificate = certificatesManager.generateCertificate(certificateInfos, entry, null, false);
@@ -267,6 +269,7 @@ public class CertificationTest extends OlatJerseyTestCase {
Identity assessedIdentity = JunitTestHelper.createAndPersistIdentityAsRndUser("cert-15");
Identity author = JunitTestHelper.createAndPersistIdentityAsAuthor("cert-5");
RepositoryEntry entry = JunitTestHelper.deployBasicCourse(author);
+ dbInstance.commitAndCloseSession();
CertificateInfos certificateInfos = new CertificateInfos(assessedIdentity, 2.0f, true);
Certificate certificate = certificatesManager.generateCertificate(certificateInfos, entry, null, false);
@@ -284,6 +287,8 @@ public class CertificationTest extends OlatJerseyTestCase {
// check that there is a real certificate with its file
Certificate reloadedCertificate = certificatesManager.getCertificateById(certificate.getKey());
+ Certificate lastCertificate = certificatesManager.getLastCertificate(assessedIdentity, entry.getOlatResource().getKey());
+ Assert.assertEquals(reloadedCertificate, lastCertificate);
VFSLeaf certificateFile = certificatesManager.getCertificateLeaf(reloadedCertificate);
Assert.assertNotNull(certificateFile);
Assert.assertTrue(certificateFile.exists());
--
GitLab